rustbuild: fix dist in debug mode#45382
Merged
Merged
Conversation
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
kennytm
added
the
S-waiting-on-review
Member
|
However, I will note that distributing a debug compiler is almost certainly not what you want to do, since it will be very slow (10x or more, last I heard). @bors r+ rollup |
Collaborator
|
📌 Commit 27cc119 has been approved by |
kennytm
added
S-waiting-on-bors
Contributor
Author
|
Would definitely not recommend that for production, but useful to get nice stacks in case of a segfault |
Member
|
To an extent, though usually not worth it. rustc, thankfully, rarely segfaults. |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 19, 2017
rustbuild: fix dist in debug mode In debug mode, the artifacts are placed in "debug", so don't hardcode "release" and use our helper to get the right directory name
bors
added a commit
that referenced
this pull request
Oct 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In debug mode, the artifacts are placed in "debug", so don't hardcode "release" and use our helper to get the right directory name