Skip to content

Remove semicolon note #46258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 10 commits into from
Nov 28, 2017
Merged

Remove semicolon note #46258

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
aabacf7
Remove semicolon note
colinmarsh19 Nov 25, 2017
ba40f5c
Test for issue #46186
colinmarsh19 Nov 25, 2017
306f4da
Fixed Err by passing "err"
colinmarsh19 Nov 25, 2017
8e60f72
Added ;
colinmarsh19 Nov 25, 2017
3e8883e
Changed from note to span_suggestion_short
colinmarsh19 Nov 26, 2017
4779899
UI test 46186
colinmarsh19 Nov 26, 2017
bbe4c85
Added 46186 stderr
colinmarsh19 Nov 26, 2017
50537e3
Delete bad test file
colinmarsh19 Nov 26, 2017
f6b80d4
Added .rs extension
colinmarsh19 Nov 26, 2017
096e698
Changed to correct quotes ` `
colinmarsh19 Nov 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed Err by passing "err"
  • Loading branch information
@colinmarsh19
colinmarsh19 authored Nov 25, 2017
commit 306f4da69a89f45b9c06ac742f337e6de0445845
2 changes: 1 addition & 1 deletion src/libsyntax/parse/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5490,7 +5490,7 @@ impl<'a> Parser<'a> {
if token_str == ";" {
err.note("consider removing the semicolon");
Copy link
Contributor

@estebank estebank Nov 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this into a span_suggestion_short(span, msg, "".to_string()), so that the output points at it and tools depending on the RLS can apply the change automatically.

}
return Err();
return Err(err);
}

let hi = if self.span == syntax_pos::DUMMY_SP {
Expand Down