Skip to content

Issue 3148 #4628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikomatsakis wants to merge 3 commits into from
Closed

Issue 3148 #4628

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01bf87e
Link the lifetimes of regions resulting from borrows of the
nikomatsakis Jan 25, 2013
403f33f
Integrate vec patterns into borrow checker.
nikomatsakis Jan 25, 2013
03e9e4f
Detect "// WARN" in tidy and print out, well, a warning! Useful
nikomatsakis Jan 25, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Detect "// WARN" in tidy and print out, well, a warning! Useful 
for notating FIXME-style-situations that you want to be reminded
of before you commit.
  • Loading branch information
@nikomatsakis
nikomatsakis committed Jan 25, 2013
commit 03e9e4f5f99265f88dee1b9d1b3f624a10d7e40e
8 changes: 8 additions & 0 deletions src/etc/tidy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ def report_error_name_no(name, no, s):
def report_err(s):
report_error_name_no(fileinput.filename(), fileinput.filelineno(), s)

def report_warn(s):
print("%s:%d: %s" % (fileinput.filename(),
fileinput.filelineno(),
s))

def do_license_check(name, contents):
if not check_license(name, contents):
report_error_name_no(name, 1, "incorrect license")
Expand All @@ -44,6 +49,9 @@ def do_license_check(name, contents):
report_err("FIXME without issue number")
if line.find("TODO") != -1:
report_err("TODO is deprecated; use FIXME")
if line.find("// WARN") != -1:
mo = re.match("// WARN (.*)", line)
report_warn("WARN: " + mo.group(1))
if (line.find('\t') != -1 and
fileinput.filename().find("Makefile") == -1):
report_err("tab character")
Expand Down