Merged
Conversation
The fallible version of for_each and the stateless version of try_fold.
Contributor
|
r? @aidanhs (rust_highfive has picked a reviewer for you, use r? to override) |
emilyalbini
added
the
S-waiting-on-review
Centril
added
the
T-libs-api
Contributor
|
r? @dtolnay |
Member
|
@rfcbot fcp merge |
|
Team member @dtolnay has proposed to merge this. The next step is review by the rest of the tagged teams: No concerns currently listed. Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
the
proposed-final-comment-period
Member
|
@dtolnay proposal cancelled. |
rfcbot
removed
the
proposed-final-comment-period
dtolnay
approved these changes
Feb 16, 2018
Member
|
@bors r+ |
Collaborator
|
📌 Commit 0bb818c has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 19, 2018
Add Iterator::try_for_each The fallible version of `for_each` aka the stateless version of `try_fold`. Inspired by @cuviper's comment in rust-lang#45379 (comment) as a more direct and obvious solution than `.map(f).collect::<Result<(), _>>()`. Like `for_each`, no need for an `r` version thanks to overrides in `Rev`. `iterator_try_fold` tracking issue: rust-lang#45594
4 tasks
bors
added a commit
that referenced
this pull request
Feb 20, 2018
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 23, 2018
Add Iterator::try_for_each The fallible version of `for_each` aka the stateless version of `try_fold`. Inspired by @cuviper's comment in rust-lang#45379 (comment) as a more direct and obvious solution than `.map(f).collect::<Result<(), _>>()`. Like `for_each`, no need for an `r` version thanks to overrides in `Rev`. `iterator_try_fold` tracking issue: rust-lang#45594
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallible version of
for_eachaka the stateless version oftry_fold. Inspired by @cuviper's comment in #45379 (comment) as a more direct and obvious solution than.map(f).collect::<Result<(), _>>().Like
for_each, no need for anrversion thanks to overrides inRev.iterator_try_foldtracking issue: #45594