Fixed #48425 : Various functions taking a TyCtxt and a Span should be taking a TyCtxtAt

[PramodBisht]

Hi @oli-obk
I have done some code refactoring to fix #48425, Please let me know if anything else is required on this.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[PramodBisht]

Fixing conflicts.

[oli-obk]

r? @oli-obk

@nikomatsakis can you add me to the list of ppl who can give bors commands? I can't do that yet, even though I can be assigned as a reviewer

[oli-obk]

@PramodBisht please squash the commits into one. You can do that with git rebase -i origin/master and git push --force-with-lease afterwards. The code lgtm

r=me with commits squashed

[hanna-kruppe]

@bors delegate=oli-obk

[bors]

✌️ @oli-obk can now approve this pull request

[bors]

✌️ @oli-obk can now approve this pull request

[bors]

✌️ @oli-obk can now approve this pull request

[PramodBisht]

@oli-obk I am not able to rebase it because of merge commits, is there any other way around to deal with that. Let me know if I should recommit and raise PR from another branch.

[oli-obk]

Huh? Merge commits shouldn't matter. Can you paste the entire error?

[PramodBisht]

@oli-obk can you come on IRC, can we discuss there?

[PramodBisht]

@oli-obk right after running git rebase -i origin/master, I am getting this

error: could not apply 4882331... Fixed #48425

When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase --abort".
Could not apply 4882331b3772958718986e4ecbf70eb34e3a2fb2... Fixed #48425

master is in sync with main rust-lang/rust master

[oli-obk]

Sorry I'm on vacation. This is perfectly normal. Just look through the changes, remove all the things you did not change, git add the final document and then run git rebase --continue if anything is out of order, change it and run git commit --amend

[nikomatsakis]

@oli-obk hmm. you ought to have them soon. =)

[PramodBisht]

@oli-obk All set, could you please check again :)

[oli-obk]

Jup looks good now

@bors r+

[bors]

📌 Commit 6fdf637 has been approved by oli-obk