Update libc to 0.2.39#48859
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors: r+ |
|
📌 Commit ebfdb5f has been approved by |
bors
added
the
S-waiting-on-bors
|
@Mark-Simulacrum I think this should just be "CC" rather than "Fixes" for #42681 since the bootstrap is a piece that needs to be updated to fully fix the problem. Thanks for reopening it. |
|
You mean we need to backport to beta and bootstrap from that beta? |
|
I don't know the process for updating the beta but I wasn't going to push to update it for #42681. I think waiting for other reasons is fine. I assume that whatever the next update is would use whatever the current libc is from master right? |
|
Releasing a new beta is trivial, and if simply backporting a libc bump to beta is enough to fix what looks like a somewhat painful regression, then we should do it. Once that's done we can update master to boostrap from that beta instead of the original beta. |
|
🔒 Merge conflict |
bors
added
S-waiting-on-author
|
☔ The latest upstream changes (presumably #48549) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Merge conflict resolved via rebase, now only libc submodule updated. |
|
@bors: r+ |
|
📌 Commit c63d5e0 has been approved by |
bors
added
S-waiting-on-bors
Update libc to 0.2.39 CC #42681 r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
5 participants
CC #42681
r? @alexcrichton