Update rustfmt and rls by nrc · Pull Request #50236 · rust-lang/rust

nrc · 2018-04-25T23:01:36Z

r? @alexcrichton

rust-highfive · 2018-04-25T23:01:47Z

Warning

These commits modify submodules.

alexcrichton · 2018-04-25T23:12:47Z

@bors: r+ p=1

bors · 2018-04-25T23:12:48Z

📌 Commit 127f9a6 has been approved by alexcrichton

bors · 2018-04-26T01:57:19Z

⌛ Testing commit 127f9a6 with merge d5d4f231c0617fb87903c842992873c4a00cb7b0...

bors · 2018-04-26T02:16:09Z

💔 Test failed - status-travis

rust-highfive · 2018-04-26T02:16:11Z

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:02:45]  Downloading rustc-serialize v0.3.24
[00:02:46]  Downloading idna v0.1.4
[00:02:46]  Downloading either v1.5.0
[00:02:46]  Downloading rls-vfs v0.4.5
[00:02:46]  Downloading skeptic v0.13.2
[00:02:46]  Downloading open v1.2.1
[00:02:47]  Downloading diff v0.1.11
[00:02:47]  Downloading rls-rustc v0.2.2
[00:02:47]  Downloading walkdir v1.0.7
---
[00:16:17] * wrapping_int_impl                lib      unstable     None    
[00:16:17] * wrapping_iter_arith              lib      stable       1.14.0  
[00:16:17] * wrapping_neg                     lib      stable       1.10.0  
[00:16:17] * wrapping_ref                     lib      stable       1.14.0  
[00:16:18] invalid license MPL-2.0 in /checkout/obj/build/tmp/distcheck/src/vendor/colored/Cargo.toml
[00:16:18] some tidy checks failed
[00:16:18] 
[00:16:18] 
[00:16:18] command did not execute successfully: "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/tmp/distcheck/src" "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0/bin/cargo"
[00:16:18] 
[00:16:18] 
[00:16:18] failed to run: /checkout/obj/build/tmp/distcheck/build/bootstrap/debug/bootstrap test
[00:16:18] Build completed unsuccessfully in 0:03:07
[00:16:18] Build completed unsuccessfully in 0:03:07
[00:16:18] make: *** [check] Error 1
[00:16:18] Makefile:58: recipe for target 'check' failed
[00:16:18] 
[00:16:18] 
[00:16:18] command did not execute successfully: "make" "check"
[00:16:18] 
[00:16:18] 
[00:16:18] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:16:18] Build completed unsuccessfully in 0:13:08

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-04-26T02:16:14Z

The job x86_64-gnu-distcheck of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:02:45]  Downloading rustc-serialize v0.3.24
[00:02:46]  Downloading idna v0.1.4
[00:02:46]  Downloading either v1.5.0
[00:02:46]  Downloading rls-vfs v0.4.5
[00:02:46]  Downloading skeptic v0.13.2
[00:02:46]  Downloading open v1.2.1
[00:02:47]  Downloading diff v0.1.11
[00:02:47]  Downloading rls-rustc v0.2.2
[00:02:47]  Downloading walkdir v1.0.7
---
[00:16:17] * wrapping_int_impl                lib      unstable     None    
[00:16:17] * wrapping_iter_arith              lib      stable       1.14.0  
[00:16:17] * wrapping_neg                     lib      stable       1.10.0  
[00:16:17] * wrapping_ref                     lib      stable       1.14.0  
[00:16:18] invalid license MPL-2.0 in /checkout/obj/build/tmp/distcheck/src/vendor/colored/Cargo.toml
[00:16:18] some tidy checks failed
[00:16:18] 
[00:16:18] 
[00:16:18] command did not execute successfully: "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/tmp/distcheck/src" "/checkout/obj/build/tmp/distcheck/build/x86_64-unknown-linux-gnu/stage0/bin/cargo"
[00:16:18] 
[00:16:18] 
[00:16:18] failed to run: /checkout/obj/build/tmp/distcheck/build/bootstrap/debug/bootstrap test
[00:16:18] Build completed unsuccessfully in 0:03:07
[00:16:18] Build completed unsuccessfully in 0:03:07
[00:16:18] make: *** [check] Error 1
[00:16:18] Makefile:58: recipe for target 'check' failed
[00:16:18] 
[00:16:18] 
[00:16:18] command did not execute successfully: "make" "check"
[00:16:18] 
[00:16:18] 
[00:16:18] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test distcheck
[00:16:18] Build completed unsuccessfully in 0:13:08

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

nrc · 2018-04-26T03:10:57Z

r? @alexcrichton for the second commit which adds a license check exception

alexcrichton · 2018-04-26T03:15:25Z

@bors: r+

bors · 2018-04-26T03:15:26Z

📌 Commit 612830d has been approved by alexcrichton

bors · 2018-04-26T03:36:33Z

⌛ Testing commit 612830d with merge c187787...

@alexcrichton

Update rustfmt and rls r? @alexcrichton

bors · 2018-04-26T05:47:50Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c187787 to master...

kennytm-githubbot · 2018-04-26T05:49:08Z

📣 Toolstate changed by #50236!

Tested on commit c187787.
Direct link to PR: #50236

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.
💔 rustfmt on windows: test-pass → test-fail (cc @nrc).
💔 rustfmt on linux: test-pass → test-fail (cc @nrc).

@nrc

Tested on commit rust-lang/rust@c187787. Direct link to PR: <rust-lang/rust#50236> 🎉 rls on windows: build-fail → test-pass. 🎉 rls on linux: build-fail → test-pass. 💔 rustfmt on windows: test-pass → test-fail (cc @nrc). 💔 rustfmt on linux: test-pass → test-fail (cc @nrc).

nrc · 2018-04-26T09:21:56Z

@kennytm can I get the logs for the rustfmt test failure at all? I can't reproduce the failure locally on Linux (./x.py test src/tools/rustfmt passes)

kennytm · 2018-04-26T09:41:19Z

@nrc The raw log is in https://api.travis-ci.org/v3/job/371374420/log.txt, the test failures are:

[01:37:28] failures:
[01:37:28] 
[01:37:28] ---- test::verify_check_works stdout ----
[01:37:28] 	thread 'test::verify_check_works' panicked at 'No such file or directory (os error 2)', /cargo/registry/src/github.com-1ecc6299db9ec823/assert_cli-0.5.4/src/assert.rs:368:13
[01:37:28] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[01:37:28] 
[01:37:28] ---- test::verify_diff_works stdout ----
[01:37:28] 	thread 'test::verify_diff_works' panicked at 'No such file or directory (os error 2)', /cargo/registry/src/github.com-1ecc6299db9ec823/assert_cli-0.5.4/src/assert.rs:368:13
[01:37:28] 
[01:37:28] 
[01:37:28] failures:
[01:37:28]     test::verify_check_works
[01:37:28]     test::verify_diff_works
[01:37:28] 
[01:37:28] test result: FAILED. 56 passed; 2 failed; 0 ignored; 0 measured; 0 filtered out

nrc · 2018-04-26T20:21:17Z

Thanks @kennytm !

Update rustfmt and rls

127f9a6

rust-highfive assigned alexcrichton Apr 25, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 25, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 25, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 26, 2018

handle license check

612830d

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2018

bors added a commit that referenced this pull request Apr 26, 2018

Auto merge of #50236 - nrc:update, r=alexcrichton

c187787

Update rustfmt and rls r? @alexcrichton

bors merged commit 612830d into rust-lang:master Apr 26, 2018

This was referenced Apr 26, 2018

Implement a sandbox for environment variables and files #49387

Closed

WIP: Parallelize passes using rayon #46564

Closed

Uh oh!

Conversation

nrc commented Apr 25, 2018

Uh oh!

rust-highfive commented Apr 25, 2018

Uh oh!

alexcrichton commented Apr 25, 2018

Uh oh!

bors commented Apr 25, 2018

Uh oh!

bors commented Apr 26, 2018

Uh oh!

bors commented Apr 26, 2018

Uh oh!

rust-highfive commented Apr 26, 2018

Uh oh!

rust-highfive commented Apr 26, 2018

Uh oh!

nrc commented Apr 26, 2018

Uh oh!

alexcrichton commented Apr 26, 2018

Uh oh!

bors commented Apr 26, 2018

Uh oh!

bors commented Apr 26, 2018

Uh oh!

bors commented Apr 26, 2018

Uh oh!

kennytm-githubbot commented Apr 26, 2018

Uh oh!

nrc commented Apr 26, 2018

Uh oh!

kennytm commented Apr 26, 2018

Uh oh!

nrc commented Apr 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants