librustc: Forbid pub or priv before trait implementations#5131
Closed
pcwalton wants to merge 3 commits into
Closed
librustc: Forbid pub or priv before trait implementations#5131pcwalton wants to merge 3 commits into
pub or priv before trait implementations#5131pcwalton wants to merge 3 commits into
Conversation
Contributor
|
Once this lands, we can close #3985. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
…p1995 Do not lint `unnecessary_unwrap` in external macros Fixes rust-lang#5131 I think we shouldn't lint `{panicking, unnecessary}_unwrap` in macros, not just `assert!`. changelog: Fix false positive in `unnecessary_unwrap`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 7, 2023
Added remove unused imports assist This resolves the most important part of rust-lang#5131. I needed to make a couple of cosmetic changes to the search infrastructure to do this. A few open questions: * Should imports that don't resolve to anything be considered unused? I figured probably not, but it would be a trivial change to make if we want it. * Is there a cleaner way to make the edits to the use list? * Is there a cleaner way to get the list of uses that intersect the current selection? * Is the performance acceptable? When testing this on itself, it takes a good couple seconds to perform the assist. * Is there a way to hide the rustc diagnostics that overlap with this functionality?
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jun 27, 2026
move nextest section up and mark it more clearly as such
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @catamorphism (last commit is the important one)