rustbuild: drop color handling#54323
Merged
Merged
Conversation
Let cargo handle that for us Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
Contributor
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
r? @alexcrichton cc @rust-lang/infra |
emilyalbini
added
the
beta-nominated
Member
|
Hm, was it confirmed that this actually fixes things? This was originally done due to |
Member
|
probably we don't really want the ANSI color for rustc in the CI since we all read the raw log anyway 😛 |
Contributor
Author
|
It fixes bootstrapping using cargo from the latest beta here |
Member
|
@Keruspe can you check to make sure that |
Member
|
Based on the issue it looks like the logic may have been actually upstreamed into cargo, could you track down/cite the relevant Cargo PR? I think that would help make sure the logic is in fact equivalent. |
Contributor
Author
|
@alexcrichton seems to work fine here, I get colors from both cargo and rustc (still testing with cargo from the beta branch). @Mark-Simulacrum seems to be rust-lang/cargo@f1c783b |
pnkfelix
added
the
T-infra
Member
Collaborator
|
📌 Commit 2a45057 has been approved by |
bors
added
S-waiting-on-bors
Contributor
Author
|
All my testing has been done using rustc and cargo from the beta commit
mentioned earlier
…On Thu 20 Sep 2018 at 19:05, bors ***@***.***> wrote:
📌 Commit 2a45057
<2a45057>
has been approved by Mark-Simulacrum
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#54323 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AANm3scNlpTDhXlOAzwjWkvw4gIZWOrlks5uc8rTgaJpZM4Wt4IU>
.
|
Mark-Simulacrum
added
the
beta-accepted
Member
|
@bors p=1 (needs to be backported) |
Member
|
@bors: p=0 we've got a lot of backports in the queue right now and this one's pretty minor, so I think it's safe if we hold off on this to land naturally |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Sep 21, 2018
rustbuild: drop color handling Let cargo handle that for us Fixes rust-lang#54322 Needs a beta backport
bors
added a commit
that referenced
this pull request
Sep 21, 2018
Rollup of 10 pull requests Successful merges: - #53652 (define copy_within on slices) - #54261 (Make `dyn` a keyword in the 2018 edition) - #54317 (Implement the dbg!(..) macro) - #54323 (rustbuild: drop color handling) - #54371 (add -Zui-testing to rustdoc) - #54374 (Make 'proc_macro::MultiSpan' public.) - #54402 (Use no_default_libraries for all NetBSD flavors) - #54412 (add applicability to span_suggestion call) - #54413 (Add UI test for deref recursion limit printing twice) - #54422 (Simplify slice's first(_mut) and last(_mut) with get)
emilyalbini
added a commit
to emilyalbini/rust
that referenced
this pull request
Sep 22, 2018
rustbuild: drop color handling Let cargo handle that for us Fixes rust-lang#54322 Needs a beta backport
bors
added a commit
that referenced
this pull request
Sep 22, 2018
Rollup of 16 pull requests Successful merges: - #53652 (define copy_within on slices) - #54261 (Make `dyn` a keyword in the 2018 edition) - #54280 (remove (more) CAS API from Atomic* types where not natively supported) - #54323 (rustbuild: drop color handling) - #54350 (Support specifying edition in doc test) - #54370 (Improve handling of type bounds in `bit_set.rs`.) - #54371 (add -Zui-testing to rustdoc) - #54374 (Make 'proc_macro::MultiSpan' public.) - #54402 (Use no_default_libraries for all NetBSD flavors) - #54409 (Detect `for _ in in bar {}` typo) - #54412 (add applicability to span_suggestion call) - #54413 (Add UI test for deref recursion limit printing twice) - #54415 (parser: Tweak function parameter parsing to avoid rollback on succesfull path) - #54420 (Compress `Liveness` data some more.) - #54422 (Simplify slice's first(_mut) and last(_mut) with get) - #54446 (Unify christianpoveda's emails) Failed merges: - #54058 (Introduce the partition_dedup/by/by_key methods for slices) r? @ghost
bors
added a commit
that referenced
this pull request
Sep 22, 2018
Rollup of 16 pull requests Successful merges: - #53652 (define copy_within on slices) - #54261 (Make `dyn` a keyword in the 2018 edition) - #54280 (remove (more) CAS API from Atomic* types where not natively supported) - #54323 (rustbuild: drop color handling) - #54350 (Support specifying edition in doc test) - #54370 (Improve handling of type bounds in `bit_set.rs`.) - #54371 (add -Zui-testing to rustdoc) - #54374 (Make 'proc_macro::MultiSpan' public.) - #54402 (Use no_default_libraries for all NetBSD flavors) - #54409 (Detect `for _ in in bar {}` typo) - #54412 (add applicability to span_suggestion call) - #54413 (Add UI test for deref recursion limit printing twice) - #54415 (parser: Tweak function parameter parsing to avoid rollback on succesfull path) - #54420 (Compress `Liveness` data some more.) - #54422 (Simplify slice's first(_mut) and last(_mut) with get) - #54446 (Unify christianpoveda's emails) Failed merges: - #54058 (Introduce the partition_dedup/by/by_key methods for slices) r? @ghost
emilyalbini
removed
the
beta-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let cargo handle that for us
Fixes #54322
Needs a beta backport