libsyntax: Don't allow impl (Trait) for Type (with the parentheses).#5616
Closed
pcwalton wants to merge 1 commit into
Closed
libsyntax: Don't allow impl (Trait) for Type (with the parentheses).#5616pcwalton wants to merge 1 commit into
impl (Trait) for Type (with the parentheses).#5616pcwalton wants to merge 1 commit into
Conversation
bors
added a commit
that referenced
this pull request
Mar 29, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 27, 2020
…,flip1995 new_without_default: do not suggest deriving --- changelog: do not suggest deriving `Default` in `new_without_default` This commit changes the behavior of the `new_without_default` lint to not suggest deriving `Default`. This suggestion is misleading if the `new` implementation does something different than what a derived `Default` implementation would do, because then the two methods would not be equivalent. Instead, the `can_derive_default` check is removed, and we always suggest implementing `Default` in terms of `new()`.
This was referenced Oct 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @brson