Optimize try_mark_green and eliminate the lock on dep node colors by Zoxc · Pull Request #57065 · rust-lang/rust

Zoxc · 2018-12-22T17:04:49Z

Blocked on #56614

r? @michaelwoerister

Zoxc · 2018-12-22T17:10:17Z

@bors try

bors · 2018-12-22T17:10:29Z

⌛ Trying commit 84aa34d621f10826957bb64c08699307a3f69fc3 with merge 2897f68c5b419b38ac5e1a32910abe9112ea8a3c...

bors · 2018-12-22T19:37:37Z

☀️ Test successful - status-travis
State: approved= try=True

michaelwoerister · 2018-12-22T20:31:21Z

Nice :) This is something I wanted to try out for a while. (I haven't looked at the specific implementation here yet though).

@rust-timer build 2897f68c5b419b38ac5e1a32910abe9112ea8a3c

Zoxc · 2018-12-23T00:31:55Z

@rust-timer build 2897f68c5b419b38ac5e1a32910abe9112ea8a3c

rust-timer · 2018-12-23T00:31:56Z

Success: Queued 2897f68c5b419b38ac5e1a32910abe9112ea8a3c with parent fa922ab, comparison URL.

rust-timer · 2018-12-23T03:04:00Z

Finished benchmarking try commit 2897f68c5b419b38ac5e1a32910abe9112ea8a3c

michaelwoerister · 2019-01-07T12:22:50Z

This is another case where measuring with parallel queries would be useful...

Zoxc · 2019-01-07T16:27:08Z

@michaelwoerister Benchmarks on x86 won't be useful, since the atomic operations lowers to regular load/stores, so this literally just removes the lock on dep node colors.

michaelwoerister · 2019-01-08T09:09:48Z

I know but that lock can only be really expensive with parallel queries because of contention, right?

bors · 2019-01-15T01:50:28Z

☔ The latest upstream changes (presumably #57607) made this pull request unmergeable. Please resolve the merge conflicts.

michaelwoerister

It would have been nice to have a performance comparison for the multi-threaded case but that's complicated and not really worth the effort. The changes already show a small win in single-threaded mode and it can only improve the situation with parallel queries, so let's go ahead and merge.

r=me with the nits addressed.

Great work, @Zoxc!

michaelwoerister · 2019-01-15T08:50:10Z

Could you add a doc comment here? Something like "Try to mark a dep-node green for which we already know that it existed in the previous compilation session".

michaelwoerister · 2019-01-15T08:55:58Z

We already do the debug assertion a few lines above. You can just remove this one (and move the comment up).

michaelwoerister · 2019-01-15T08:58:44Z

Could you move this comment into the None branch of the match below?

Zoxc · 2019-01-15T09:47:24Z

@bors r=michaelwoerister

bors · 2019-01-15T09:47:25Z

📌 Commit 1313678 has been approved by michaelwoerister

@michaelwoerister

Optimize try_mark_green and eliminate the lock on dep node colors Blocked on rust-lang#56614 r? @michaelwoerister

@ghost

Rollup of 6 pull requests Successful merges: - #56884 (rustdoc: overhaul code block lexing errors) - #57065 (Optimize try_mark_green and eliminate the lock on dep node colors) - #57107 (Add a regression test for mutating a non-mut #[thread_local]) - #57268 (Add a target option "merge-functions", and a corresponding -Z flag (works around #57356)) - #57551 (resolve: Add a test for issue #57539) - #57598 (Add missing unpretty option help message) Failed merges: r? @ghost

@michaelwoerister

Optimize try_mark_green and eliminate the lock on dep node colors Blocked on rust-lang#56614 r? @michaelwoerister

@michaelwoerister

Optimize try_mark_green and eliminate the lock on dep node colors Blocked on rust-lang#56614 r? @michaelwoerister

@michaelwoerister

Optimize try_mark_green and eliminate the lock on dep node colors Blocked on rust-lang#56614 r? @michaelwoerister

bors · 2019-01-18T11:34:21Z

⌛ Testing commit 1313678 with merge 527b8d4...

@michaelwoerister

Optimize try_mark_green and eliminate the lock on dep node colors Blocked on #56614 r? @michaelwoerister

bors · 2019-01-18T14:21:41Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: michaelwoerister
Pushing 527b8d4 to master...

rust-highfive assigned michaelwoerister Dec 22, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 22, 2018

Zoxc force-pushed the graph-tweaks branch from 84aa34d to 1bfc43f Compare January 9, 2019 17:19

Zoxc force-pushed the graph-tweaks branch from 1bfc43f to 8e88833 Compare January 15, 2019 06:13

michaelwoerister reviewed Jan 15, 2019

View reviewed changes

Zoxc added 2 commits January 15, 2019 10:39

Optimize try_mark_green and eliminate the lock on dep node colors

8ef7413

Address comments

1313678

Zoxc force-pushed the graph-tweaks branch from 8e88833 to 1313678 Compare January 15, 2019 09:46

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2019

Centril added a commit to Centril/rust that referenced this pull request Jan 15, 2019

Rollup merge of rust-lang#57065 - Zoxc:graph-tweaks, r=michaelwoerister

0936d02

Optimize try_mark_green and eliminate the lock on dep node colors Blocked on rust-lang#56614 r? @michaelwoerister

Centril mentioned this pull request Jan 15, 2019

Rollup of 6 pull requests #57637

Closed

Centril added a commit to Centril/rust that referenced this pull request Jan 17, 2019

Rollup merge of rust-lang#57065 - Zoxc:graph-tweaks, r=michaelwoerister

e3cfe66

Optimize try_mark_green and eliminate the lock on dep node colors Blocked on rust-lang#56614 r? @michaelwoerister

Centril mentioned this pull request Jan 17, 2019

Rollup of 19 pull requests #57687

Closed

Centril added a commit to Centril/rust that referenced this pull request Jan 17, 2019

Rollup merge of rust-lang#57065 - Zoxc:graph-tweaks, r=michaelwoerister

d53dd10

Optimize try_mark_green and eliminate the lock on dep node colors Blocked on rust-lang#56614 r? @michaelwoerister

Centril mentioned this pull request Jan 17, 2019

Rollup of 19 pull requests #57688

Closed

Centril added a commit to Centril/rust that referenced this pull request Jan 17, 2019

Rollup merge of rust-lang#57065 - Zoxc:graph-tweaks, r=michaelwoerister

d552d34

Optimize try_mark_green and eliminate the lock on dep node colors Blocked on rust-lang#56614 r? @michaelwoerister

Centril mentioned this pull request Jan 17, 2019

Rollup of 18 pull requests #57690

Closed

bors added a commit that referenced this pull request Jan 18, 2019

Auto merge of #57065 - Zoxc:graph-tweaks, r=michaelwoerister

527b8d4

Optimize try_mark_green and eliminate the lock on dep node colors Blocked on #56614 r? @michaelwoerister

bors merged commit 1313678 into rust-lang:master Jan 18, 2019

Zoxc deleted the graph-tweaks branch January 28, 2019 18:33

aturon mentioned this pull request Aug 16, 2019

Audit sources of shared state across rustc #63643

Closed

37 tasks

Uh oh!

Conversation

Zoxc commented Dec 22, 2018

Uh oh!

Zoxc commented Dec 22, 2018

Uh oh!

bors commented Dec 22, 2018

Uh oh!

bors commented Dec 22, 2018

Uh oh!

michaelwoerister commented Dec 22, 2018

Uh oh!

Zoxc commented Dec 23, 2018

Uh oh!

rust-timer commented Dec 23, 2018

Uh oh!

rust-timer commented Dec 23, 2018

Uh oh!

michaelwoerister commented Jan 7, 2019

Uh oh!

Zoxc commented Jan 7, 2019

Uh oh!

michaelwoerister commented Jan 8, 2019

Uh oh!

bors commented Jan 15, 2019

Uh oh!

michaelwoerister left a comment

Choose a reason for hiding this comment

Uh oh!

michaelwoerister Jan 15, 2019

Choose a reason for hiding this comment

Uh oh!

michaelwoerister Jan 15, 2019

Choose a reason for hiding this comment

Uh oh!

michaelwoerister Jan 15, 2019

Choose a reason for hiding this comment

Uh oh!

Zoxc commented Jan 15, 2019

Uh oh!

bors commented Jan 15, 2019

Uh oh!

bors commented Jan 18, 2019

Uh oh!

bors commented Jan 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants