Skip to content

Exclude old book redirect stubs from search engines#59197

Merged
bors merged 1 commit into
rust-lang:masterfrom
kornelski:redir
Mar 27, 2019
Merged

Exclude old book redirect stubs from search engines#59197
bors merged 1 commit into
rust-lang:masterfrom
kornelski:redir

Conversation

@kornelski

@kornelski kornelski commented Mar 14, 2019

Copy link
Copy Markdown
Contributor

Adds <meta name="robots" content="noindex,follow"> to the <head> of old stub pages pointing to the second edition of the book.

This is continuation of rust-lang/book#1788

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 14, 2019
@QuietMisdreavus

Copy link
Copy Markdown
Contributor

Seems fine to me, but since this is primarily a bootstrap change, i want to get another set of eyes on it, to make sure that it's only affecting the book redirects.

r? @Mark-Simulacrum

@steveklabnik

Copy link
Copy Markdown
Contributor

Same question as the robots.txt one; this loses all of our google juice, right?

@kornelski

kornelski commented Mar 20, 2019

Copy link
Copy Markdown
Contributor Author

With caveat that SEO is mostly speculation…

The meta includes follow, so it should pass its "juice" through to all of its links (based on understanding of PageRank, which may or may not be relevant today, but that was the last time Google had their ranking documented in writing).

Even for pages entirely hidden from the index I expect search engines to contribute the links to overall ranking/authority of the domain (that's how seomoz models rankings).

I also expect this to improve ranking of the docs domain by improving CTR and reducing bounce rate (these are metrics tracked by Google). From what I've observed, Google seems to limit results to a few pages from each domain, and these stubs crowd-out actual book from results. Having them gone should make room for the real book.

And finally, users complain about being unable to find Rust documentation they're looking for, so having some highly-ranked pages, if they aren't helpful to users, isn't good.

@Mark-Simulacrum

Copy link
Copy Markdown
Member

r? @steveklabnik for SEO approval, from a rustbuild point of view looks fine

@steveklabnik

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

Yep, thanks @kornelski , that seems to match what I've read about this too. Appreciate your patience.

@bors

bors commented Mar 26, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 8b5a748 has been approved by steveklabnik

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2019
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 26, 2019
Exclude old book redirect stubs from search engines

Adds `<meta name="robots" content="noindex,follow">` to the `<head>` of old stub pages pointing to the second edition of the book.

This is continuation of rust-lang/book#1788
bors added a commit that referenced this pull request Mar 26, 2019
Rollup of 7 pull requests

Successful merges:

 - #59004 ([rustdoc] Improve "in parameters" search and search more generally)
 - #59026 (Fix moving text in search tabs headers)
 - #59197 (Exclude old book redirect stubs from search engines)
 - #59330 (Improve the documentation for std::convert (From, Into, AsRef and AsMut))
 - #59424 (Fix code block display in portability element in dark theme)
 - #59427 (Link to PhantomData in NonNull documentation)
 - #59432 (Improve some compiletest documentation)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Mar 27, 2019
Rollup of 7 pull requests

Successful merges:

 - #59004 ([rustdoc] Improve "in parameters" search and search more generally)
 - #59026 (Fix moving text in search tabs headers)
 - #59197 (Exclude old book redirect stubs from search engines)
 - #59330 (Improve the documentation for std::convert (From, Into, AsRef and AsMut))
 - #59424 (Fix code block display in portability element in dark theme)
 - #59427 (Link to PhantomData in NonNull documentation)
 - #59432 (Improve some compiletest documentation)

Failed merges:

r? @ghost
@bors bors merged commit 8b5a748 into rust-lang:master Mar 27, 2019
@kornelski kornelski deleted the redir branch March 27, 2019 18:27
@matklad

matklad commented Apr 20, 2020

Copy link
Copy Markdown
Contributor

Hm, the original problem still reproduces for me:

image

Is this issue considered fully fix, or is there some additional issue I can subscribe to and 👍 ?

@kornelski

Copy link
Copy Markdown
Contributor Author

Blocked by #68677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants