Skip to content

Fix stack overflow when generating debuginfo for 'recursive' type #59446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 6 commits into from
Apr 2, 2019
Merged

Fix stack overflow when generating debuginfo for 'recursive' type #59446

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
512069f
Fix stack overflow when generating debuginfo for 'recursive' type
Aaron1011 Mar 26, 2019
e1837a0
Fix inverted panic check
Aaron1011 Mar 26, 2019
aed7ec4
Add codegen test
Aaron1011 Mar 27, 2019
c4556a5
Fix typos
Aaron1011 Mar 28, 2019
d2584e3
Only track 'visited' state for function types
Aaron1011 Apr 1, 2019
c13daeb
Fix typo
Aaron1011 Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo
  • Loading branch information
@Aaron1011
Aaron1011 authored Apr 1, 2019
commit c13daeb036273d3fd0544c3cc58592f2a86d1631
2 changes: 1 addition & 1 deletion src/librustc_codegen_llvm/debuginfo/type_names.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ pub fn push_debuginfo_type_name<'a, 'tcx>(cx: &CodegenCx<'a, 'tcx>,
// (e.g. MyType<fn() -> u8, fn() -> u8>
//
// We only care about avoiding recursing
// directly back to the type we're currentlu
// directly back to the type we're currently
// processing
visited.remove(t);
},
Expand Down