Cleanup to syntax::print/rustc::hir::print#62098
Closed
Mark-Simulacrum wants to merge 4 commits intorust-lang:masterfrom
Closed
Cleanup to syntax::print/rustc::hir::print#62098Mark-Simulacrum wants to merge 4 commits intorust-lang:masterfrom
Mark-Simulacrum wants to merge 4 commits intorust-lang:masterfrom
Conversation
rust-highfive
added
the
S-waiting-on-review
Contributor
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
|
I don't understand the larger picture of excising So r=me on that. |
Contributor
|
That said, cc @petrochenkov and @eddyb. |
Member
Author
|
The larger goal is mostly just a simplification of the code, which may lead to both compile time wins ( |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 0091e6e has been approved by |
bors
added
S-waiting-on-bors
eddyb
reviewed
Jun 25, 2019
|
|
||
| pub struct Printer<'a> { | ||
| out: Box<dyn io::Write+'a>, | ||
| out: &'a mut Vec<u8>, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation for a removal of
io::Result<()>from all of the printing infrastructure methods (separate PR due to huge diff), along with potentially some other cleanups.r? @Centril (but feel free to reassign if there's someone better -- there's no functional changes here)