Skip to content

[WIP] rustc: temporarily disable non-syntactic elision.#62181

Closed
eddyb wants to merge 2 commits intorust-lang:masterfrom
eddyb:syn-only-elision
Closed

[WIP] rustc: temporarily disable non-syntactic elision.#62181
eddyb wants to merge 2 commits intorust-lang:masterfrom
eddyb:syn-only-elision

Conversation

@eddyb
Copy link
Member

@eddyb eddyb commented Jun 27, 2019

This is only exists so we can do a quick crater check-only run, which we should've probably done a long time ago, but this behavior persisted undisturbed and unquestioned (possible for a good reason).

r? @nikomatsakis

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 27, 2019
@eddyb
Copy link
Member Author

eddyb commented Jun 27, 2019

@bors try

@bors
Copy link
Collaborator

bors commented Jun 27, 2019

⌛ Trying commit 4d81f33 with merge 37165ca20a5b26004da6c770516fc0aa431c6ad6...

@bors
Copy link
Collaborator

bors commented Jun 27, 2019

💔 Test failed - checks-azure

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2019
@eddyb
Copy link
Member Author

eddyb commented Jun 27, 2019

@bors retry

@bors
Copy link
Collaborator

bors commented Jun 27, 2019

⌛ Trying commit 4d81f33 with merge 37b1007bcf383c6620fd0e921068d4c38501f18c...

@bors
Copy link
Collaborator

bors commented Jun 27, 2019

💔 Test failed - checks-azure

@eddyb
Copy link
Member Author

eddyb commented Jul 1, 2019

Blocked on #62247.

@eddyb eddyb added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 1, 2019
nikomatsakis
nikomatsakis approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@nikomatsakis nikomatsakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm curious to see the results.

@lqd
Copy link
Member

lqd commented Jul 1, 2019

(#62247 has landed, so let's see if these try permissions work)

@bors retry

@bors
Copy link
Collaborator

bors commented Jul 1, 2019

⌛ Trying commit 4d81f33 with merge 003a7b6...

bors added a commit that referenced this pull request Jul 1, 2019
@bors
Auto merge of #62181 - eddyb:syn-only-elision, r=<try>
003a7b6 
[WIP] rustc: temporarily disable non-syntactic elision.

This is only exists so we can do a quick crater check-only run, which we should've probably done a long time ago, but this behavior persisted undisturbed and unquestioned (possible for a good reason).

r? @nikomatsakis
@bors bors mentioned this pull request Jul 1, 2019
Merged
@bors
Copy link
Collaborator

bors commented Jul 2, 2019

☀️ Try build successful - checks-azure, checks-travis
Build commit: 003a7b6

@eddyb
Copy link
Member Author

eddyb commented Jul 2, 2019

@craterbot run mode=check-only

@craterbot
Copy link
Collaborator

craterbot commented Jul 2, 2019

👌 Experiment pr-62181 created and queued.
🤖 Automatically detected try build 003a7b6
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jul 2, 2019
@craterbot
Copy link
Collaborator

craterbot commented Jul 2, 2019

🚧 Experiment pr-62181 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jul 2, 2019
@craterbot
Copy link
Collaborator

craterbot commented Jul 6, 2019

🎉 Experiment pr-62181 is completed!
📊 40 regressed and 0 fixed (66894 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jul 6, 2019
@craterbot craterbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 6, 2019
@taiki-e taiki-e mentioned this pull request Jul 15, 2019
Merged
@edmilsonefs
Copy link

edmilsonefs commented Jul 22, 2019

Hey! This is a ping from triage, we would like to know if you @eddyb could give us a few more minutes to update here so we can move forward .

Thanks.

@edmilsonefs
Copy link

edmilsonefs commented Jul 22, 2019

@rustbot modify labels to +S-waiting-on-author, -S-waiting-on-review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2019
@eddyb
Copy link
Member Author

eddyb commented Jul 23, 2019

The experiment is done.

@eddyb eddyb closed this Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@eddyb @bors @lqd @craterbot @edmilsonefs @nikomatsakis @rust-highfive @rustbot