Merged
Conversation
bump rand in libcore/liballoc test suites This pulls in the fix for rust-random/rand#779, which trips Miri when running these test suites. `SmallRng` (formerly used by libcore) is no longer built by default, it needs a feature gate. I opted to switch to `StdRng` instead. Or should I enable the feature gate?
…imulacrum Update rustfmt to 1.4.4 The update includes bug fixes.
Add an overflow check in truncate implementation for Unix. Closes rust-lang#63326. cc @alexcrichton
…ichton Don't use remap-path-prefix in dep-info files. This changes it so that dep-info files do not use remapped paths. Having remapped paths causes problems with Cargo because if you remap to a nonexistent path (like `/rustc/$HASH` which rustc distributions do), then Cargo's change tracking thinks the files don't exist and will always rebuild. I don't actually know if this is a good idea. I think it makes sense, but I do not know what the exact requirements are for reproducible builds. I consider these files separate from the binary artifacts generated, and as a build-system helper, so it seems reasonable to me. I'm also not sure if this needs a test. I'll definitely add one on the cargo side if this is merged. Closes rust-lang#63329
…r=Centril doc: Fix typo in float from bytes methods Thanks @That3Percent for pointing it out. r? @Centril
Improved documentation for compile_error!() Fixes rust-lang#63375
…-obk Add test for issue 53096 Closes rust-lang#53096 r? @oli-obk
Contributor
Author
|
@bors r+ p=8 rollup=never |
Collaborator
|
📌 Commit 3de450b has been approved by |
Collaborator
|
⌛ Testing commit 3de450b with merge c215a1de6ce23d152a8303b6c95f63d420eaffea... |
Contributor
|
Your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Collaborator
|
💔 Test failed - checks-azure |
Contributor
Author
|
@bors retry spurious network. |
Collaborator
bors
added a commit
that referenced
this pull request
Aug 8, 2019
Rollup of 8 pull requests Successful merges: - #63261 (bump rand in libcore/liballoc test suites) - #63316 (Update rustfmt to 1.4.4) - #63332 (Add an overflow check in truncate implementation for Unix.) - #63342 (Don't use remap-path-prefix in dep-info files.) - #63366 (doc: Fix typo in float from bytes methods) - #63370 (Fix ICE #63364) - #63377 (Improved documentation for compile_error!()) - #63379 (Add test for issue 53096) Failed merges: r? @ghost
Collaborator
|
☀️ Test successful - checks-azure |
This was referenced Aug 8, 2019
pchickey
added a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Aug 26, 2020
issue now closed: rust-lang/rust#63326 fix landed in a rollup: rust-lang/rust#63380 merged aug 8, 2019 rust 1.38 beta cut on aug 15, 2019: https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html
pchickey
added a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Aug 26, 2020
issue now closed: rust-lang/rust#63326 fix landed in a rollup: rust-lang/rust#63380 merged aug 8, 2019 rust 1.38 beta cut on aug 15, 2019: https://blog.rust-lang.org/2019/08/15/Rust-1.37.0.html minimum supported rust version for this repo is currently 1.41.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
u16range whose bounds exceed 64k #63364)Failed merges:
r? @ghost