Skip to content

Improved error message for break in async block#63659

Merged
bors merged 1 commit into
rust-lang:masterfrom
gilescope:async-in-closure
Aug 18, 2019
Merged

Improved error message for break in async block#63659
bors merged 1 commit into
rust-lang:masterfrom
gilescope:async-in-closure

Conversation

@gilescope

@gilescope gilescope commented Aug 17, 2019

Copy link
Copy Markdown
Contributor

Fixes #63391

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2019
@gilescope gilescope changed the title Less confusing error message. Improved error message for break in async block Aug 17, 2019
Comment thread src/librustc_passes/loops.rs Outdated
@Centril

Centril commented Aug 17, 2019

Copy link
Copy Markdown
Contributor

r? @Centril

r=me rollup with comment addressed.

@rust-highfive rust-highfive assigned Centril and unassigned varkor Aug 17, 2019
@Centril

Centril commented Aug 18, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Aug 18, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit 1e02bc6 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 18, 2019
Improved error message for break in async block

Fixes rust-lang#63391
@bors

bors commented Aug 18, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 1e02bc6 with merge 4cf7673...

bors added a commit that referenced this pull request Aug 18, 2019
Improved error message for break in async block

Fixes #63391
@bors

bors commented Aug 18, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 4cf7673 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 18, 2019
@bors bors merged commit 1e02bc6 into rust-lang:master Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve diagnostic for break in async { ... } block

5 participants