fix #64430, confusing owned_box error message in no_std build#64439
Merged
bors merged 3 commits intorust-lang:masterfrom Sep 14, 2019
Merged
fix #64430, confusing owned_box error message in no_std build#64439bors merged 3 commits intorust-lang:masterfrom
owned_box error message in no_std build#64439bors merged 3 commits intorust-lang:masterfrom
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @zackmdavis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Sep 13, 2019
| try_alt_rcvr(&mut err, arc_rcvr_t); | ||
| let rc_rcvr_t = self.tcx.mk_lang_item(rcvr_t, lang_items::Rc); | ||
| try_alt_rcvr(&mut err, rc_rcvr_t); | ||
| try_alt_rcvr(&mut err, rcvr_t, lang_items::OwnedBoxLangItem); |
Contributor
There was a problem hiding this comment.
Nice! 👍 -- this bug fix turned out to make the code cleaner 🎉
Contributor
|
r? @Centril Can you please also include a regression test that fail with the "no method named..." error rather than the "requires XX lang_item"? Ideally, the test should cover Box, Rc, and Arc. |
Centril
added
S-waiting-on-author
Contributor
|
Thanks! r=me when green. |
Contributor
Author
|
r= @Centril |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit e484f21 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 14, 2019
fix rust-lang#64430, confusing `owned_box` error message in no_std build Fixes rust-lang#64430
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 14, 2019
fix rust-lang#64430, confusing `owned_box` error message in no_std build Fixes rust-lang#64430
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 14, 2019
fix rust-lang#64430, confusing `owned_box` error message in no_std build Fixes rust-lang#64430
bors
added a commit
that referenced
this pull request
Sep 14, 2019
Rollup of 17 pull requests Successful merges: - #63846 (Added table containing the system calls used by Instant and SystemTime.) - #64116 (Fix minor typo in docs.) - #64203 (A few cosmetic improvements to code & comments in liballoc and libcore) - #64302 (Shrink `ObligationCauseCode`) - #64372 (use randSecure and randABytes) - #64374 (Box `DiagnosticBuilder`.) - #64375 (Fast path for vec.clear/truncate ) - #64378 (Fix inconsistent link formatting.) - #64384 (Trim rustc-workspace-hack) - #64393 ( declare EnvKey before use to fix build error) - #64420 (Inline `mark_neighbours_as_waiting_from`.) - #64422 (Remove raw string literal quotes from error index descriptions) - #64423 (Add self to .mailmap) - #64425 (typo fix) - #64431 (fn ptr is structural match) - #64435 (codegen: use "_N" (like for other locals) instead of "argN", for argument names.) - #64439 (fix #64430, confusing `owned_box` error message in no_std build) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64430