implement FromIterator<char> for Box<str>#65168
Closed
Duddino wants to merge 12 commits intorust-lang:masterfrom
Duddino:master
Closed
implement FromIterator<char> for Box<str>#65168Duddino wants to merge 12 commits intorust-lang:masterfrom Duddino:master
Duddino wants to merge 12 commits intorust-lang:masterfrom
Duddino:master
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @TimNN (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
sinkuu
reviewed
Oct 6, 2019
src/liballoc/boxed.rs
Outdated
Comment on lines
1078
to
1080
| let mut buf = String::new(); | ||
| buf.extend(iter); | ||
| buf.into_boxed_str() |
Contributor
There was a problem hiding this comment.
Can the string creation reuse String::from_iter?
String::from_iter(iter).into_boxed_str()
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
bluss
added
the
T-libs-api
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Member
Contributor
|
Re-assigning to the libs team: r? @KodrAus |
src/liballoc/boxed.rs
Outdated
| } | ||
| } | ||
|
|
||
| #[unstable(feature = "box_str_from_iter", issue = "0")] |
Member
There was a problem hiding this comment.
impls are going to be insta-stable, you can probably make this just be stable with the same feature name
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Author
|
What should I write for "since"? 1.39.0 doesn't work |
Contributor
|
It should be 1.40.0 |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
KodrAus
reviewed
Oct 23, 2019
Dylan-DPC-zz
added
S-waiting-on-author
|
Ping from Triage: any update @Duddino? |
Author
|
I'm going to fix it later this day |
KodrAus
reviewed
Nov 4, 2019
|
|
||
| #[test] | ||
| fn box_str_from_iter(){ | ||
| let iter = (0..100).map(|_|{'☺'}); |
| //! | ||
| //! # Examples | ||
| //! | ||
| //! A pointer type for heap allocation. |
Contributor
There was a problem hiding this comment.
It looks like our docs might still be a little confused here, because they've changed on master since you fixed them up.
Would you like to try squashing your 12 commits down and rebase on master?
Member
|
Box is |
Contributor
|
@sfackler that should only be a concern for generic impls, because it could break downstream crates. This should be fine because it is just for |
Member
Member
Member
JohnCSimon
added
the
S-inactive
Member
|
Unfortunately this PR has sat idle for awhile and I'm closing this as inactive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry in advance if I did something wrong, it's my first pull request