Conversation
|
Well, seems like I've broken something =_= I will investigate it and fix tomorrow. |
|
Well, I forgot to re-export public |
wesleywiser
left a comment
There was a problem hiding this comment.
looks good and ci is green
|
@bors r+ |
|
📌 Commit a06b205 has been approved by |
|
⌛ Testing commit a06b205 with merge 2f58955296a705deee35afb6edd0edad6f489650... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
|
Hm. There was Should be fixed now. P.S. It would be nice to have a tool which will check any configuration combination to be valid to detect things like this without waiting a merge queue to fail. |
|
@bors r+ |
|
📌 Commit ae04dc8 has been approved by |
|
@bors rollup=never p=1 |
Refactor libtest ## Short overview `libtest` got refactored and splitted into smaller modules ## Description `libtest` module is already pretty big and hard to understand. Everything is mixed up: CLI, console output, test execution, etc. This PR splits `libtest` into smaller logically-consistent modules, makes big functions smaller and more readable, and adds more comments, so `libtest` will be easier to understand and maintain. Although there are a lot of changes, all the refactoring is "soft", meaning that no public interfaces were affected and nothing should be broken. Thus this PR (at least should be) completely backward-compatible. r? @wesleywiser cc @Centril
|
☀️ Test successful - checks-azure |
|
Looks like this broke the external compiletest-rs crate (used by Clippy and Miri): Manishearth/compiletest-rs#197 Miri is fine right now by using the |
Short overview
libtestgot refactored and splitted into smaller modulesDescription
libtestmodule is already pretty big and hard to understand. Everything is mixed up: CLI, console output, test execution, etc.This PR splits
libtestinto smaller logically-consistent modules, makes big functions smaller and more readable, and adds more comments, solibtestwill be easier to understand and maintain.Although there are a lot of changes, all the refactoring is "soft", meaning that no public interfaces were affected and nothing should be broken.
Thus this PR (at least should be) completely backward-compatible.
r? @wesleywiser
cc @Centril