Skip to content

Use heuristics to suggest assignment #65566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 5 commits into from
Oct 27, 2019
Merged

Use heuristics to suggest assignment #65566

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6206a5a
Use heuristics to suggest assignment
estebank Oct 18, 2019
55e4e2d
Remove unnecessary error in test
estebank Oct 18, 2019
93bb780
review comments and tweaks
estebank Oct 19, 2019
7ea28e7
review comment: use `Default`
estebank Oct 19, 2019
b579c5a
Fix rebase
estebank Oct 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review comment: use Default
  • Loading branch information
@estebank
estebank committed Oct 26, 2019
commit 7ea28e761f76a4cfc030acb4c3f0792ca4ab1497
11 changes: 2 additions & 9 deletions src/librustc_resolve/late.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ impl<'a> PathSource<'a> {
}
}

#[derive(Default)]
struct DiagnosticMetadata {
/// The current trait's associated types' ident, used for diagnostic suggestions.
current_trait_assoc_types: Vec<Ident>,
Expand Down Expand Up @@ -547,15 +548,7 @@ impl<'a, 'b> LateResolutionVisitor<'a, '_> {
},
label_ribs: Vec::new(),
current_trait_ref: None,
diagnostic_metadata: DiagnosticMetadata {
current_trait_assoc_types: Vec::new(),
current_self_type: None,
current_self_item: None,
current_function: None,
unused_labels: Default::default(),
current_type_ascription: Vec::new(),
current_let_binding: None,
}
diagnostic_metadata: DiagnosticMetadata::default(),
}
}

Expand Down