remove dependency on itertools#68999
Conversation
rust-highfive
added
the
S-waiting-on-review
There was a problem hiding this comment.
I can't say I'm a fan of this change. Sure, itertools takes some compile time, but I think we should use it more, to be able to write nice declarative code like before this diff. I'm sure there are quite a few places in the compiler where we could clean things up with a more active "do use itertools" policy.
There was a problem hiding this comment.
I can support that I was only feeling that it was a lot of time for use of one function.
also now for some reason itertools is built twice think that is solved even with this file reverted.
There was a problem hiding this comment.
Yeah I get that. :) I'd be happy to r+ the rest of the PR though for now.
There was a problem hiding this comment.
fixed the comment now
feels like window for iterators can be in std as there is an version for slices.
|
@bors r+ |
|
📌 Commit 3b23d22 has been approved by |
bors
added
S-waiting-on-bors
remove dependency on itertools r? @Centril
Rollup of 11 pull requests Successful merges: - #67695 (Added dyn and true keyword docs) - #68487 ([experiment] Support linking from a .rlink file) - #68554 (Split lang_items to crates `rustc_hir` and `rustc_passes`.) - #68937 (Test failure of unchecked arithmetic intrinsics in const eval) - #68947 (Python script PEP8 style guide space formatting and minor Python source cleanup) - #68999 (remove dependency on itertools) - #69026 (Remove common usage pattern from `AllocRef`) - #69027 (Add missing `_zeroed` varants to `AllocRef`) - #69058 (Preparation for allocator aware `Box`) - #69070 (Add self to .mailmap) - #69077 (Fix outdated doc comment.) Failed merges: r? @ghost
4 participants
r? @Centril