Remove marker comments in libstd/lib.rs macro imports#70824
Remove marker comments in libstd/lib.rs macro imports#70824bors merged 1 commit intorust-lang:masterfrom yoshuawuyts:fix-labels-in-std-macro-imports
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
These labels were probably moved around when rustfmt was introduced.
|
I agree that they're not useful, so approving, but if rustfmt did move things around please file (on the rustfmt repository) an issue as that shouldn't happen. @bors r+ rollup |
|
📌 Commit 004ce25 has been approved by |
bors
added
S-waiting-on-bors
|
@Mark-Simulacrum my guess is rustfmt alphabetized the imports when it was introduced, which messed up the semantic meaning of the the comments. This seems somewhat expected, and I'm not sure how rustfmt could have done a better job at this. When removing the labels rustfmt likely was able to fit all imports on two lines again, so a hence the reduced line count in this patch. |
It could have interpreted the comments as semantic boundaries across which it is not allowed to reformat. |
Rollup of 7 pull requests Successful merges: - rust-lang#70553 (move OS constants to platform crate) - rust-lang#70665 (Do not lose or reorder user-provided linker arguments) - rust-lang#70750 (Match options directly in the Fuse implementation) - rust-lang#70782 (Stop importing the float modules in documentation) - rust-lang#70798 ("cannot resolve" → "cannot satisfy") - rust-lang#70808 (Simplify dtor registration for HermitCore by using a list of destructors) - rust-lang#70824 (Remove marker comments in libstd/lib.rs macro imports) Failed merges: r? @ghost
6 participants
These comments were probably moved around when rustfmt was introduced. They don't correctly denote what they were intended for, so I propose we remove them instead. Thanks!