Prefer cmake3 to cmake when bootstrapping.#71262
Closed
alexreg wants to merge 2 commits into
Closed
Conversation
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
(Tested on CentOS on GCC Compile Farm, incidentally.) |
joelpalmer
added
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #71717) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
@alexreg Ping from triage, this needs a rebase. |
crlf0710
added
S-waiting-on-author
Contributor
Author
|
@crlf0710 Happy to rebase right after a review... don't want to rebase just for it to sit around a while longer waiting for a review. :-) |
|
@alexreg mark will review it this week, so better to rebase before that :) |
Contributor
Author
|
@Dylan-DPC In that case, no prob. Shouldn't bitrot much (if at all) in a few days! |
joelpalmer
added
S-waiting-on-author
|
Ping from Triage: Any update @alexreg? |
Elinvynia
added
S-waiting-on-author
Member
|
Going to close this out as inactive. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #71227.
r? @Mark-Simulacrum