Error code explanation extra check#71350
Conversation
a80dba8 to
28a9725
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
28a9725 to
a447640
Compare
|
CI passed. |
There was a problem hiding this comment.
This test is a major change to the previous one and doesn't reflect what the text around it says
There was a problem hiding this comment.
It'll need to be updated I guess. But before, it wasn't throwing the correct error code.
a447640 to
d8402bd
Compare
There was a problem hiding this comment.
this still has the wrong explanation
There was a problem hiding this comment.
Yes but it has to be fixed in another PR. ;)
There was a problem hiding this comment.
ok, can you open an issue about it?
There was a problem hiding this comment.
Open an issue with a list of these error codes and the goal to remove this constant
|
CI failed, though I'm not sure what's wrong, there's little information. Maybe spurious @bors r+ |
|
📌 Commit d8402bd6cd00d9a1d05b592ed45a986a65a980fb has been approved by |
…rror code and also that 'compile_fail' isn't mispelled
d8402bd to
5cdea2d
Compare
|
@bors r+ |
|
📌 Commit 5cdea2d has been approved by |
Rollup of 5 pull requests Successful merges: - rust-lang#71256 (Lint must_use on mem::replace) - rust-lang#71350 (Error code explanation extra check) - rust-lang#71369 (allow wasm32 compilation of librustc_data_structures/profiling.rs) - rust-lang#71400 (proc_macro::is_available()) - rust-lang#71440 (Implement `Copy` for `AllocErr`) Failed merges: r? @ghost
r? @Mark-Simulacrum