Merged
Conversation
Pulls in updated MSVC detection logic landed in alexcrichton/cc-rs#488
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
Author
|
Given bugs like https://github.com/alexcrichton/cc-rs/issues/493 I think this may also be a good candidate for backporting since it should be pretty low-risk and may be good to accelerate getting this out to users. |
Member
|
Looks like the diff here is alexcrichton/cc-rs@1.0.50...1.0.52 -- that all looks reasonable to me. I agree that the MSVC version detection logic being broken on at least some systems it seems good to backport this so I'm going to go ahead and nominate. @bors r+ |
Collaborator
|
📌 Commit 3318187 has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added
beta-nominated
Contributor
|
discussed at T-compiler meeting. Accepted for beta-backport. |
pnkfelix
added
the
beta-accepted
Mark-Simulacrum
removed
the
beta-nominated
Merged
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 10, 2020
…lacrum Update the `cc` crate Pulls in updated MSVC detection logic landed in alexcrichton/cc-rs#488
This was referenced May 10, 2020
|
@bors p=1 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 10, 2020
Rollup of 4 pull requests Successful merges: - rust-lang#71840 (Rework MIR drop tree lowering) - rust-lang#71882 (Update the `cc` crate) - rust-lang#71945 (Sort "implementations on foreign types" section in the sidebar) - rust-lang#72043 (Add missing backtick in E0569 explanation) Failed merges: r? @ghost
Collaborator
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2020
…ulacrum [beta] backports This backport rollup includes the following: * [beta] Update cargo rust-lang#71967 * Backport 1.43.1 release notes to master rust-lang#71914 * Update the `cc` crate rust-lang#71882 * resolve: Relax fresh binding disambiguation slightly to fix regression rust-lang#71846 * Do not try to find binop method on RHS `TyErr` rust-lang#71810 * Quick and dirty fix of the unused_braces lint rust-lang#71517 * Update stdarch submodule rust-lang#71495 * normalize field projection ty to fix broken MIR issue rust-lang#71488 * Update openssl-src to 1.1.1g rust-lang#71430 * fix error code in E0751.md rust-lang#71426 * Don't fuse Chain in its second iterator rust-lang#71404 * Remove some `Vec` allocations to improve performance rust-lang#71268 * [CI] Use the latest Python available on Windows rust-lang#71995 It also switches the bootstrap compiler to 1.43.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in updated MSVC detection logic landed in alexcrichton/cc-rs#488