Allow rust-highfive to label issues it creates.#72395
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @RalfJung |
|
r? @Mark-Simulacrum (feel free to further re-assign...) |
kennytm
left a comment
kennytm
left a comment
There was a problem hiding this comment.
the code looks fine to me, except that LABELS could use a list directly rather than sets.
cc @rust-lang/wg-triage, are you ok with these choices of labels?
|
@Elinvynia Could you update the sets to lists? With that done I think we can merge this in. Thanks! |
|
Can you also squash the commits into one? Thanks! r=me with that done |
Replace sets with lists.
|
?r=me |
|
"r=me" is code for "tell bors to approve this PR in my name". It is also entire inscrutable unless you already know it, and contributors without bors permission cannot use it anyway. But it tells me I can now do this: |
|
📌 Commit dc4b9fd has been approved by |
bors
added
S-waiting-on-bors
Rollup of 7 pull requests Successful merges: - rust-lang#71289 (Allow using `Self::` in doc) - rust-lang#72375 (Improve E0599 explanation) - rust-lang#72385 (Add some teams to prioritization exclude_labels) - rust-lang#72395 (Allow rust-highfive to label issues it creates.) - rust-lang#72453 (Add flag to open docs: x.py doc --open) - rust-lang#72459 (Add core::future::IntoFuture) - rust-lang#72461 (Clean up E0600 explanation) Failed merges: r? @ghost
8 participants
This is my first meaningful PR, I am unsure how to test this code so any pointers would be welcome!
I am about 50% sure it works.