?Sized bounds for rc::Weak::as_ptr and friends#74022
Closed
CAD97 wants to merge 1 commit intorust-lang:masterfrom
Closed
?Sized bounds for rc::Weak::as_ptr and friends#74022CAD97 wants to merge 1 commit intorust-lang:masterfrom
CAD97 wants to merge 1 commit intorust-lang:masterfrom
Conversation
....to allow use with unsized T. This is a follow-up to rust-lang#73845, which did the impl work required to be able to relax these bounds.
Contributor
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
...whoops, this apparently isn't quite possible yet. Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, this relaxes the bounds on
rc::Weak::as_ptr,into_raw, andfrom_rawfromimpl<T> Weak<T>toimpl<T: ?Sized> Weak<T>.This is a follow-up to #73845, which did the impl work required to be able to relax these bounds.
IIUC, this technically stabilizes that "something like
size_of_val_raw" is possible to do. However, I believe the part of the functionality required by these methods here -- specifically, getting the size of a pointee from a pointer where it may be dangling iff the pointee isSized-- is uncontroversial enough to stabilize these methods without a way to implement them on stable Rust.ATTN: This changes (relaxes) the (input) generic bounds on stable
fn!