Update MinGW instructions to include ninja#76134
Merged
Merged
Conversation
Added the `mingw-w64-x86_64-ninja` package to the build guide for MinGW, as well as a note not to use the `ninja` package from the `msys2` subsystem (doesn't handle paths correctly on windows).
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
@bors r+ rollup=always |
Collaborator
|
📌 Commit 00d459a has been approved by |
bors
added
S-waiting-on-bors
matklad
added a commit
to matklad/rust
that referenced
this pull request
Aug 31, 2020
Update MinGW instructions to include ninja Rust now requires `ninja` to build, so the MinGW build instructions are updated to reflect this. Like for `python` and `cmake`, the `mingw-w64-x86_64-ninja` package should be used. The default package from the `msys2` subsystem doesn't handle paths correctly on windows.
This was referenced Aug 31, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2020
Rollup of 9 pull requests Successful merges: - rust-lang#75969 (Switch to intra-doc links in core/src/{convert,iter}/mod.rs) - rust-lang#76023 (Liballoc extend use intra doc link) - rust-lang#76033 (Add missing hyphen) - rust-lang#76052 (rust-langGH-66816: Remove disable attr before return) - rust-lang#76055 (Keep doc standard for Vec DrainFilter) - rust-lang#76058 (Use assertions on Vec doc) - rust-lang#76069 (Use explicit intra-doc link in path for Vec resize) - rust-lang#76117 (Update README.md) - rust-lang#76134 (Update MinGW instructions to include ninja) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust now requires
ninjato build, so the MinGW build instructions are updated to reflect this.Like for
pythonandcmake, themingw-w64-x86_64-ninjapackage should be used. The default package from themsys2subsystem doesn't handle paths correctly on windows.