Stabilize `Poll::is_ready` and `is_pending` as const by CDirkx · Pull Request #76227 · rust-lang/rust

CDirkx · 2020-09-02T00:37:28Z

Insta-stabilize the methods is_ready and is_pending of std::task::Poll as const, in the same way as PR#76198.

Possible because of the recent stabilization of const control flow.

Part of #76225.

Insta-stabilize the methods `is_ready` and `is_pending` of `Poll`. Possible because of the recent stabilization of const control flow. Also adds a test for these methods in a const context.

rust-highfive · 2020-09-02T00:37:31Z

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

matklad · 2020-09-02T13:00:00Z

src/test/ui/consts/std/poll.rs

+
+    const IS_PENDING : bool = POLL.is_pending();
+    assert!(IS_PENDING);
+}


Hm, why are we using a UI test for this, especially a run-pass one? I would think that these integrated tests are much costlier than standard #[test] tests, as well as much harder to debug. Linking a whole separate executable to check two const methods of stdlib is an overkill.

I would suggest testing similar things by unit or integrated #[test] tests in core or std itself.

It might also be a good idea to sift through existing test suite for stdlib tests which can be moved to unit tests.

Hm, yeah, we already have a bunch of tests like this...

I've opened https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/UI.20tests.20for.20stdlib for discussion, it might be that I am missing some context here of course.

The conclusion is that we want to move such tests to library/: #76268

@CDirkx if you could move some of the already existing const tests in a similar way, that would be awesome :)

Sounds good, I'll have a look later today

Tests are moved 👍

shepmaster · 2020-09-02T15:32:27Z

r? @Amanieu

Same deal as #76198 (comment) ?

Part of rust-lang#76268

Dylan-DPC-zz · 2020-09-29T23:58:30Z

r? @KodrAus

KodrAus · 2020-09-30T14:01:23Z

This seems reasonable to me. Thanks @CDirkx!

@rfcbot fcp merge

This stabilizes the following boolean-style match methods on Poll as const:

impl<T> Poll<T> {
    pub const fn is_ready(&self) -> bool;
    pub const fn is_pending(&self) -> bool;
}

rfcbot · 2020-09-30T14:01:24Z

Team member @KodrAus has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2020-10-16T02:31:37Z

🔔 This is now entering its final comment period, as per the review above. 🔔

dtolnay · 2020-10-16T03:05:09Z

@bors r+

rfcbot · 2020-10-26T02:32:02Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

CDirkx · 2020-11-07T02:15:16Z

Did this get added to the queue correctly?

Dylan-DPC-zz · 2020-11-07T02:44:33Z

@bors r=KodrAus

bors · 2020-11-07T02:44:35Z

📌 Commit 5e80c65 has been approved by KodrAus

Stabilize `Poll::is_ready` and `is_pending` as const Insta-stabilize the methods `is_ready` and `is_pending` of `std::task::Poll` as const, in the same way as [PR#76198](rust-lang#76198). Possible because of the recent stabilization of const control flow. Part of rust-lang#76225.

Rollup of 19 pull requests Successful merges: - rust-lang#76097 (Stabilize hint::spin_loop) - rust-lang#76227 (Stabilize `Poll::is_ready` and `is_pending` as const) - rust-lang#78065 (make concurrency helper more pleasant to read) - rust-lang#78570 (Remove FIXME comment in print_type_sizes ui test suite) - rust-lang#78572 (Use SOCK_CLOEXEC and accept4() on more platforms.) - rust-lang#78658 (Add a tool to run `x.py` from any subdirectory) - rust-lang#78706 (Fix run-make tests running when LLVM is disabled) - rust-lang#78728 (Constantify `UnsafeCell::into_inner` and related) - rust-lang#78775 (Bump Rustfmt and RLS) - rust-lang#78788 (Correct unsigned equivalent of isize to be usize) - rust-lang#78811 (Make some std::io functions `const`) - rust-lang#78828 (use single char patterns for split() (clippy::single_char_pattern)) - rust-lang#78841 (Small cleanup in `TypeFoldable` derive macro) - rust-lang#78842 (Honor the rustfmt setting in config.toml) - rust-lang#78843 (Less verbose debug logging from inlining integrator) - rust-lang#78852 (Convert a bunch of intra-doc links) - rust-lang#78860 (rustc_resolve: Use `#![feature(format_args_capture)]`) - rust-lang#78861 (typo and formatting) - rust-lang#78865 (Don't fire `CONST_ITEM_MUTATION` lint when borrowing a deref) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Stabilize Poll::is_ready and is_pending as const

9412a89

Insta-stabilize the methods `is_ready` and `is_pending` of `Poll`. Possible because of the recent stabilization of const control flow. Also adds a test for these methods in a const context.

rust-highfive assigned shepmaster Sep 2, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2020

CDirkx mentioned this pull request Sep 2, 2020

Stabilize enum is_variant methods as const #76225

Closed

6 tasks

matklad reviewed Sep 2, 2020

View reviewed changes

rust-highfive assigned Amanieu and unassigned shepmaster Sep 2, 2020

Amanieu added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 3, 2020

jyn514 added the A-const-fn label Sep 3, 2020

Move const tests for Poll to library\core

ce1d5ed

Part of rust-lang#76268

jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Sep 13, 2020

rust-highfive assigned KodrAus and unassigned Amanieu Sep 29, 2020

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Sep 30, 2020

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 16, 2020

dtolnay approved these changes Oct 16, 2020

View reviewed changes

camelid removed the S-waiting-on-team label Oct 16, 2020

rfcbot added to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Oct 26, 2020

spastorino removed the to-announce Announce this issue on triage meeting label Oct 29, 2020

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 7, 2020

m-ou-se mentioned this pull request Nov 7, 2020

Rollup of 12 pull requests #78831

Closed

m-ou-se mentioned this pull request Nov 7, 2020

Rollup of 15 pull requests #78838

Closed

m-ou-se mentioned this pull request Nov 7, 2020

Rollup of 16 pull requests #78846

Closed

m-ou-se mentioned this pull request Nov 7, 2020

Rollup of 15 pull requests #78851

Closed

Dylan-DPC-zz mentioned this pull request Nov 8, 2020

Rollup of 15 pull requests #78870

Closed

m-ou-se mentioned this pull request Nov 8, 2020

Rollup of 19 pull requests #78874

Merged

bors merged commit bdeace9 into rust-lang:master Nov 8, 2020

rustbot added this to the 1.49.0 milestone Nov 8, 2020

CDirkx deleted the const-poll branch November 8, 2020 17:00

dtolnay self-assigned this Mar 24, 2024

RalfJung added the A-const-eval Area: Constant evaluation, covers all const contexts (static, const fn, ...) label Dec 1, 2024

Uh oh!

Conversation

CDirkx commented Sep 2, 2020

Uh oh!

rust-highfive commented Sep 2, 2020

Uh oh!

matklad Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

matklad Sep 2, 2020

Choose a reason for hiding this comment

Uh oh!

matklad Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

CDirkx Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

CDirkx Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

shepmaster commented Sep 2, 2020

Uh oh!

Dylan-DPC-zz commented Sep 29, 2020

Uh oh!

KodrAus commented Sep 30, 2020

Uh oh!

rfcbot commented Sep 30, 2020 • edited by BurntSushi Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Oct 16, 2020

Uh oh!

dtolnay commented Oct 16, 2020

Uh oh!

rfcbot commented Oct 26, 2020

Uh oh!

CDirkx commented Nov 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Dylan-DPC-zz commented Nov 7, 2020

Uh oh!

bors commented Nov 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

rfcbot commented Sep 30, 2020 •

edited by BurntSushi

Loading

CDirkx commented Nov 7, 2020 •

edited

Loading