Properly define va_arg and va_list for aarch64-apple-darwin#78126
Merged
bors merged 2 commits intorust-lang:masterfrom Oct 26, 2020
Merged
Properly define va_arg and va_list for aarch64-apple-darwin#78126bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
Member
Author
|
r? @nagisa /cc @dlrobertson |
Member
Author
|
Please double check my configuration attributes. I definitely screwed them up two times during development. |
shepmaster
force-pushed
the
aarch64-apple-darwin-valist
branch
from
f3b1db6 to
d8aaf3d
Compare
camelid
added
the
S-waiting-on-review
shepmaster
added
C-bug
dlrobertson
reviewed
Oct 20, 2020
Contributor
dlrobertson
left a comment
dlrobertson
left a comment
There was a problem hiding this comment.
Good catch! I thought the only case we needed to force a void pointer variant of a va_list for apple was on iOS.
Member
Author
You were right! 😉 The new |
shepmaster
force-pushed
the
aarch64-apple-darwin-valist
branch
from
d8aaf3d to
59ed2cf
Compare
Contributor
|
Looks good to me! |
nagisa
reviewed
Oct 23, 2020
Member
|
r=me, your call if you want to do anything about the style comment. |
nagisa
reviewed
Oct 23, 2020
shepmaster
force-pushed
the
aarch64-apple-darwin-valist
branch
from
59ed2cf to
d6bfde4
Compare
dlrobertson
reviewed
Oct 25, 2020
Contributor
dlrobertson
left a comment
dlrobertson
left a comment
There was a problem hiding this comment.
Thanks for updating the match statement to use a match arm guard instead of the tuple matching! I think it looks a good bit cleaner.
nagisa
reviewed
Oct 25, 2020
From [Apple][]: > Because of these changes, the type `va_list` is an alias for `char*`, > and not for the struct type in the generic procedure call standard. With this change `/x.py test --stage 1 src/test/ui/abi/variadic-ffi` passes. Fixes rust-lang#78092 [Apple]: https://developer.apple.com/documentation/xcode/writing_arm64_code_for_apple_platforms
shepmaster
force-pushed
the
aarch64-apple-darwin-valist
branch
from
d6bfde4 to
0a91755
Compare
Member
|
@bors r+ |
Collaborator
|
📌 Commit 0a91755 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 26, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#74477 (`#[deny(unsafe_op_in_unsafe_fn)]` in sys/wasm) - rust-lang#77836 (transmute_copy: explain that alignment is handled correctly) - rust-lang#78126 (Properly define va_arg and va_list for aarch64-apple-darwin) - rust-lang#78137 (Initialize tracing subscriber in compiletest tool) - rust-lang#78161 (Add issue template link to IRLO) - rust-lang#78214 (Tweak match arm semicolon removal suggestion to account for futures) - rust-lang#78247 (Fix rust-lang#78192) - rust-lang#78252 (Add codegen test for rust-lang#45964) - rust-lang#78268 (Do not try to report on closures to avoid ICE) - rust-lang#78295 (Add some regression tests) Failed merges: r? `@ghost`
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Apple:
With this change
/x.py test --stage 1 src/test/ui/abi/variadic-ffipasses.
Fixes #78092