Don't link with --export-dynamic on wasm32-wasi#81255
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 1, 2021
Merged
Conversation
Remove --export-dynamic from the link arguments on the wasm32-wasi target, as it emits spurious exports and increases code size. Leave it in place for wasm32-unknown-unknown and wasm32-unknown-emscripten. Even though it isn't a great solution there, users are likely depending on its behavior there.
Contributor
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
davidtwco
approved these changes
Jan 22, 2021
Member
davidtwco
left a comment
There was a problem hiding this comment.
Implementation looks good to me but can't speak to whether the change is appropriate.
Member
Member
|
@bors: r+ |
Collaborator
|
📌 Commit 9abcfa5 has been approved by |
Collaborator
|
⌛ Testing commit 9abcfa5 with merge e60c535320e85d27f58918a87df082c1c17eceda... |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
Member
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 27, 2021
… r=alexcrichton Don't link with --export-dynamic on wasm32-wasi Remove --export-dynamic from the link arguments on the wasm32-wasi target, as it emits spurious exports and increases code size. Leave it in place for wasm32-unknown-unknown and wasm32-unknown-emscripten. Even though it isn't a great solution there, users are likely depending on its behavior there.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jan 27, 2021
… r=alexcrichton Don't link with --export-dynamic on wasm32-wasi Remove --export-dynamic from the link arguments on the wasm32-wasi target, as it emits spurious exports and increases code size. Leave it in place for wasm32-unknown-unknown and wasm32-unknown-emscripten. Even though it isn't a great solution there, users are likely depending on its behavior there.
henryboisdequin
added a commit
to henryboisdequin/rust
that referenced
this pull request
Jan 29, 2021
… r=alexcrichton Don't link with --export-dynamic on wasm32-wasi Remove --export-dynamic from the link arguments on the wasm32-wasi target, as it emits spurious exports and increases code size. Leave it in place for wasm32-unknown-unknown and wasm32-unknown-emscripten. Even though it isn't a great solution there, users are likely depending on its behavior there.
This was referenced Jan 31, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 31, 2021
…as-schievink Rollup of 11 pull requests Successful merges: - rust-lang#80092 (2229: Fix issues with move closures and mutability) - rust-lang#80404 (Remove const_in_array_repeat) - rust-lang#81255 (Don't link with --export-dynamic on wasm32-wasi) - rust-lang#81480 (Add suggestion for nested fields) - rust-lang#81549 (Misc ip documentation fixes) - rust-lang#81566 (Add a test for rust-lang#71202) - rust-lang#81568 (Fix an old FIXME in redundant paren lint) - rust-lang#81571 (Fix typo in E0759) - rust-lang#81572 (Edit multiple error code Markdown files) - rust-lang#81589 (Fix small typo in string.rs) - rust-lang#81590 (Stabilize int_bits_const) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
ZauberNerd
added a commit
to ZauberNerd/tinygo
that referenced
this pull request
Mar 18, 2022
Exporting symbols seems to embed them in the WASM exports section which causes wasmtime to fail: bytecodealliance/wasmtime#2587 As a workaround, it is possible to specify the `--allow-unknown-exports` flag on wasmtime. But as discussed in the above linked issue, this seems to only be a workaround. For the Rust compiler the fix was to remove the `--export-dynamic` linker flag when targeting `wasm32-wasi`: rust-lang/rust#81255 Which is waht this commit does for Tinygo too.
ZauberNerd
added a commit
to ZauberNerd/tinygo
that referenced
this pull request
Mar 18, 2022
Exporting symbols seems to embed them in the WASM exports section which causes wasmtime to fail: bytecodealliance/wasmtime#2587 As a workaround, it is possible to specify the `--allow-unknown-exports` flag on wasmtime. But as discussed in the above linked issue, this seems to only be a workaround. For the Rust compiler the fix was to remove the `--export-dynamic` linker flag when targeting `wasm32-wasi`: rust-lang/rust#81255 Which is waht this commit does for Tinygo too.
ZauberNerd
added a commit
to ZauberNerd/tinygo
that referenced
this pull request
Mar 18, 2022
Exporting symbols seems to embed them in the WASM exports section which causes wasmtime to fail: bytecodealliance/wasmtime#2587 As a workaround, it is possible to specify the `--allow-unknown-exports` flag on wasmtime. But as discussed in the above linked issue, this seems to only be a workaround. For the Rust compiler the fix was to remove the `--export-dynamic` linker flag when targeting `wasm32-wasi`: rust-lang/rust#81255 Which is waht this commit does for Tinygo too.
aykevl
pushed a commit
to tinygo-org/tinygo
that referenced
this pull request
Mar 19, 2022
Exporting symbols seems to embed them in the WASM exports section which causes wasmtime to fail: bytecodealliance/wasmtime#2587 As a workaround, it is possible to specify the `--allow-unknown-exports` flag on wasmtime. But as discussed in the above linked issue, this seems to only be a workaround. For the Rust compiler the fix was to remove the `--export-dynamic` linker flag when targeting `wasm32-wasi`: rust-lang/rust#81255 Which is waht this commit does for Tinygo too.
deadprogram
pushed a commit
to tinygo-org/tinygo
that referenced
this pull request
Apr 7, 2022
Exporting symbols seems to embed them in the WASM exports section which causes wasmtime to fail: bytecodealliance/wasmtime#2587 As a workaround, it is possible to specify the `--allow-unknown-exports` flag on wasmtime. But as discussed in the above linked issue, this seems to only be a workaround. For the Rust compiler the fix was to remove the `--export-dynamic` linker flag when targeting `wasm32-wasi`: rust-lang/rust#81255 Which is waht this commit does for Tinygo too.
deadprogram
pushed a commit
to tinygo-org/tinygo
that referenced
this pull request
Apr 11, 2022
Exporting symbols seems to embed them in the WASM exports section which causes wasmtime to fail: bytecodealliance/wasmtime#2587 As a workaround, it is possible to specify the `--allow-unknown-exports` flag on wasmtime. But as discussed in the above linked issue, this seems to only be a workaround. For the Rust compiler the fix was to remove the `--export-dynamic` linker flag when targeting `wasm32-wasi`: rust-lang/rust#81255 Which is waht this commit does for Tinygo too.
ardnew
pushed a commit
to ardnew/tinygo
that referenced
this pull request
Jun 21, 2022
Exporting symbols seems to embed them in the WASM exports section which causes wasmtime to fail: bytecodealliance/wasmtime#2587 As a workaround, it is possible to specify the `--allow-unknown-exports` flag on wasmtime. But as discussed in the above linked issue, this seems to only be a workaround. For the Rust compiler the fix was to remove the `--export-dynamic` linker flag when targeting `wasm32-wasi`: rust-lang/rust#81255 Which is waht this commit does for Tinygo too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove --export-dynamic from the link arguments on the wasm32-wasi
target, as it emits spurious exports and increases code size.
Leave it in place for wasm32-unknown-unknown and
wasm32-unknown-emscripten. Even though it isn't a great solution
there, users are likely depending on its behavior there.