Fix overflowing text on mobile when sidebar is displayed#81630
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 2, 2021
Merged
Fix overflowing text on mobile when sidebar is displayed#81630bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
What if you scrolled below with sidebar off and sidebar on with and without the patch? |
Member
Author
|
Didn't understand what you meant. |
pickfire
approved these changes
Feb 1, 2021
Contributor
pickfire
left a comment
pickfire
left a comment
There was a problem hiding this comment.
Based on the image, looks good to me. But I wonder what happens if the user scrolled below a bit?
Member
Author
|
I still don't understand what you mean. :-/ To be perfectly clear about this, the CSS changes I added are only applied when you click on the hamburger menu to display the sidebar. |
Contributor
|
I mean, scroll the page down a bit and try again. Press on screen, drag your finger up, release finger, finger press on hamburger button. |
Member
Author
|
No issue either? Wll, moving forward then. Thanks for the review! @bors: r=pickfire rollup |
Collaborator
|
📌 Commit 899b0dd has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 2, 2021
…as-schievink Rollup of 11 pull requests Successful merges: - rust-lang#80629 (Add lint for 2229 migrations) - rust-lang#81022 (Add Frames Iterator for Backtrace) - rust-lang#81481 (move some tests) - rust-lang#81485 (Add some tests for associated-type-bounds issues) - rust-lang#81492 (rustdoc: Note why `rustdoc::html::markdown` is public) - rust-lang#81577 (const_evaluatable: consider sub-expressions to be evaluatable) - rust-lang#81599 (Implement `TrustedLen` for `Fuse<I: TrustedLen>`) - rust-lang#81608 (Improve handling of spans around macro result parse errors) - rust-lang#81609 (Remove the remains of query categories) - rust-lang#81630 (Fix overflowing text on mobile when sidebar is displayed) - rust-lang#81631 (Remove unneeded `mut` variable) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81597.
Before:
After:
cc @pickfire
r? @Nemo157