rustdoc: Move crate loader to collect_intra_doc_links::early #84101
Merged
bors merged 2 commits intorust-lang:masterfrom Apr 12, 2021
Merged
rustdoc: Move crate loader to collect_intra_doc_links::early #84101bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
Previously, rustdoc would panic on links to external crates if they were surrounded by backticks.
jyn514
added
C-cleanup
This comment has been minimized.
This comment has been minimized.
rust-highfive
added
the
S-waiting-on-review
6 tasks
This comment has been minimized.
This comment has been minimized.
This groups the similar code together, and also allows making most of collect_intra_doc_links private again
Manishearth
approved these changes
Apr 11, 2021
Member
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
r=me, fine to land this in lieu of landing the other PR.
Member
Author
|
@bors r=Manishearth |
Collaborator
|
📌 Commit cba5073 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#83669 (Issue 81508 fix) - rust-lang#84014 (Improve trait/impl method discrepancy errors) - rust-lang#84059 (Bump libc dependency of std to 0.2.93) - rust-lang#84067 (clean up example on read_to_string) - rust-lang#84079 (Improve test for `rustdoc::bare_urls` lint) - rust-lang#84094 (Remove FixedSizeArray) - rust-lang#84101 (rustdoc: Move crate loader to collect_intra_doc_links::early ) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This groups the similar code together, and also allows making most of collect_intra_doc_links private again.
This builds on #84066, but it wouldn't be too hard to base it off master if you want this to land first.
Helps with #83761.
r? manishearth
Fixes #84046