Uses flex to fix formatting of h1 at any width#84376
Merged
bors merged 2 commits intorust-lang:masterfrom Apr 22, 2021
Merged
Conversation
Contributor
|
Some changes occurred in HTML/CSS/JS. |
Contributor
|
r? @ollie27 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
This looks OK on Safari on iPhone 6, using a fake trait name to demonstrate the wrapping. Tested on a real device using BrowserStack:
Edge also looks good:
|
Contributor
Author
|
For consistency, I do recommend also changing the other places where |
Member
|
@torhovland Thanks!
Do you want to send another PR to improve it as well? |
Member
|
In the meantime: @bors: r+ |
Collaborator
|
📌 Commit bb91805 has been approved by |
bors
added
S-waiting-on-bors
Contributor
Author
Sure, I can give it a shot. |
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 22, 2021
…Gomez Uses flex to fix formatting of h1 at any width Fixes rust-lang#84354.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 22, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#84343 (Remove `ScopeTree::closure_tree`) - rust-lang#84376 (Uses flex to fix formatting of h1 at any width) - rust-lang#84377 (Followup to rust-lang#83944) - rust-lang#84396 (Update LLVM submodule) - rust-lang#84402 (Move `sys_common::rwlock::StaticRWLock` etc. to `sys::unix::rwlock`) - rust-lang#84404 (Check for intrinsics before coercing to a function pointer) - rust-lang#84413 (Remove `sys::args::Args::inner_debug` and use `Debug` instead) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez
added
A-rustdoc-ui
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 29, 2021
Use flex more consistently Builds on rust-lang#84376, related to rust-lang#84354. - Fully replaces `float: right` with `flex` on `.content .out-of-band`. - Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.). Tested on various widths to make sure the pages behave as before.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 29, 2021
Use flex more consistently Builds on rust-lang#84376, related to rust-lang#84354. - Fully replaces `float: right` with `flex` on `.content .out-of-band`. - Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.). Tested on various widths to make sure the pages behave as before.
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Apr 29, 2021
Use flex more consistently Builds on rust-lang#84376, related to rust-lang#84354. - Fully replaces `float: right` with `flex` on `.content .out-of-band`. - Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.). Tested on various widths to make sure the pages behave as before.
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Apr 29, 2021
Use flex more consistently Builds on rust-lang#84376, related to rust-lang#84354. - Fully replaces `float: right` with `flex` on `.content .out-of-band`. - Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.). Tested on various widths to make sure the pages behave as before.
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Apr 29, 2021
Use flex more consistently Builds on rust-lang#84376, related to rust-lang#84354. - Fully replaces `float: right` with `flex` on `.content .out-of-band`. - Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.). Tested on various widths to make sure the pages behave as before.
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Apr 29, 2021
Use flex more consistently Builds on rust-lang#84376, related to rust-lang#84354. - Fully replaces `float: right` with `flex` on `.content .out-of-band`. - Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.). Tested on various widths to make sure the pages behave as before.
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Apr 29, 2021
Use flex more consistently Builds on rust-lang#84376, related to rust-lang#84354. - Fully replaces `float: right` with `flex` on `.content .out-of-band`. - Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.). Tested on various widths to make sure the pages behave as before.
jackh726
added a commit
to jackh726/rust
that referenced
this pull request
Apr 29, 2021
Use flex more consistently Builds on rust-lang#84376, related to rust-lang#84354. - Fully replaces `float: right` with `flex` on `.content .out-of-band`. - Uses `flex` more consistently with existing usage (on `h3`, `h4`, etc.). Tested on various widths to make sure the pages behave as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84354.