Simplify early compilation interface#86489
Conversation
cjgillot
commented
Jun 20, 2021
- separate resolver creation and AST configuration.
- bundle lowering with global_ctxt creation.
|
r? @jackh726 (rust-highfive has picked a reviewer for you, use r? to override) |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
|
⌛ Trying commit cc326346b3ec0657b164407f5bf89f8ee2a43e96 with merge 4559bbd8a4a11c3b934fc8dcde6319d259f6396b... |
This comment has been minimized.
This comment has been minimized.
|
☀️ Try build successful - checks-actions |
|
Queued 4559bbd8a4a11c3b934fc8dcde6319d259f6396b with parent 75d1500, future comparison URL. |
|
Finished benchmarking try commit (4559bbd8a4a11c3b934fc8dcde6319d259f6396b): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Perhaps Zoxc had something in mind when making lower_to_hir individually available, but if no tools use it right now, then it seems fine to remove.
|
@bors r+ |
|
📌 Commit f698774 has been approved by |
|
☀️ Test successful - checks-actions |