Skip to content

debuginfo: Captured variables and large pass-by-value arguments #8855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelwoerister wants to merge 7 commits into from
Closed

debuginfo: Captured variables and large pass-by-value arguments #8855

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b81ea86
debuginfo: Support for variables captured in closures and closure typ…
michaelwoerister Aug 23, 2013
30375cc
debuginfo: Support for by-value arguments (still excluding some cases…
michaelwoerister Aug 28, 2013
c19f493
debuginfo: Added test cases for structs, tuples, enums, etc passed by…
michaelwoerister Aug 29, 2013
6b2df76
debuginfo: Always copy args to allocas if debuginfo is enabled
michaelwoerister Sep 3, 2013
e0b63b0
debuginfo: Fixed some merge fallout
michaelwoerister Sep 3, 2013
c49eb07
debuginfo: Much improved handling of captured variables and by-value …
michaelwoerister Sep 3, 2013
5b94ae9
debuginfo: Fixed some merge fallout
michaelwoerister Sep 4, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
debuginfo: Always copy args to allocas if debuginfo is enabled
  • Loading branch information
@michaelwoerister
michaelwoerister committed Sep 4, 2013
commit 6b2df76c244d1cd282dd724135c4bdcb6e28eb52
22 changes: 10 additions & 12 deletions src/librustc/middle/trans/_match.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2000,19 +2000,17 @@ pub fn store_arg(mut bcx: @mut Block,
let arg_ty = node_id_type(bcx, pat.id);
add_clean(bcx, llval, arg_ty);

match simple_identifier(pat) {
Some(_) => {
// Optimized path for `x: T` case. This just adopts
// `llval` wholesale as the pointer for `x`, avoiding the
// general logic which may copy out of `llval`.
bcx.fcx.llargs.insert(pat.id, llval);
}
let fast_path = !bcx.ccx().sess.opts.extra_debuginfo && simple_identifier(pat).is_some();

None => {
// General path. Copy out the values that are used in the
// pattern.
bcx = bind_irrefutable_pat(bcx, pat, llval, BindArgument);
}
if fast_path {
// Optimized path for `x: T` case. This just adopts
// `llval` wholesale as the pointer for `x`, avoiding the
// general logic which may copy out of `llval`.
bcx.fcx.llargs.insert(pat.id, llval);
} else {
// General path. Copy out the values that are used in the
// pattern.
bcx = bind_irrefutable_pat(bcx, pat, llval, BindArgument);
}

return bcx;
Expand Down