std/extra: Two small bugfixes and one simplification#8858
Closed
bluss wants to merge 3 commits intorust-lang:masterfrom
bluss:small-bugs
Closed
std/extra: Two small bugfixes and one simplification#8858bluss wants to merge 3 commits intorust-lang:masterfrom bluss:small-bugs
bluss wants to merge 3 commits intorust-lang:masterfrom
bluss:small-bugs
Conversation
added 3 commits
August 29, 2013 17:11
Just to simplify and not have the iteration logic repeated in multiple places.
`s.slice_chars(a, b)` did not allow the case where `a == s.len()`, this is a bug I introduced last time I touched the method; add a test for this case.
Contributor
Author
|
The normalization iter change and PR #8857 together clean up some of the string iteration in |
Contributor
Author
|
I'm so sorry, I won't rebase in this stupid way again. The first listed commit ( |
bors
added a commit
that referenced
this pull request
Aug 30, 2013
Fix a bug in `s.slice_chars(a, b)` that did not accept `a == s.len()`. Fix a bug in `!=` defined for DList. Also simplify NormalizationIterator to use the CharIterator directly instead of mimicing the iteration itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in
s.slice_chars(a, b)that did not accepta == s.len().Fix a bug in
!=defined for DList.Also simplify NormalizationIterator to use the CharIterator directly instead of mimicing the iteration itself.