Add #[must_not_suspend] to some types in std#89303
Merged
bors merged 3 commits intorust-lang:masterfrom Oct 1, 2021
Merged
Conversation
Contributor
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Boddlnagg
reviewed
Sep 28, 2021
library/std/src/sync/mutex.rs
Outdated
| not(bootstrap), | ||
| must_not_suspend = "Holding a MutexGuard across suspend \ | ||
| points can cause deadlocks, delays, \ | ||
| and cause Future's to not implement `Send`" |
Contributor
There was a problem hiding this comment.
A plural-s does not go with an apostrophe (same issue rwlock.rs).
Member
|
I would personally really like to see it on |
dtolnay
approved these changes
Sep 29, 2021
Member
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
The RFC explicitly calls out MutexGuard as a motivation for the lint, so that one is a no-brainer. The other types here are all very clearly in the same category as MutexGuard — LGTM.
Member
|
@bors r+ |
Collaborator
|
📌 Commit cb8e83c has been approved by |
bors
added
S-waiting-on-bors
Member
|
Cross linking tracking issue. #83310 |
4 tasks
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 30, 2021
Add `#[must_not_suspend]` to some types in std I am not sure what else should have it? `Ref`?
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 30, 2021
Add `#[must_not_suspend]` to some types in std I am not sure what else should have it? `Ref`?
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 1, 2021
…arth Rollup of 8 pull requests Successful merges: - rust-lang#88782 (Fix ICE when `start` lang item has wrong generics) - rust-lang#89202 (Resolve infered types when complaining about unexpected call type ) - rust-lang#89248 (Suggest similarly named associated items in trait impls) - rust-lang#89303 (Add `#[must_not_suspend]` to some types in std) - rust-lang#89306 (thread: implements available_concurrency on haiku) - rust-lang#89314 (fix(lint): don't suggest refutable patterns to "fix" irrefutable bind) - rust-lang#89370 (CTFE: tweak aggregate rvalue handling) - rust-lang#89392 (bootstrap: Update comment in config.library.toml.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure what else should have it?
Ref?