Side-step ICE on RePlaceholder in eval_verify_bound#89890
Closed
estebank wants to merge 1 commit into
Closed
Conversation
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
Contributor
|
r? @rust-lang/borrowck |
This comment has been minimized.
This comment has been minimized.
Contributor
|
I had a look at this, and I think that the correct fix is to replace the placeholder regions in the type here rust/compiler/rustc_borrowck/src/type_check/constraint_conversion.rs Lines 98 to 111 in 40ebd07 Do you want to update this PR to do that, or should I open a new PR with that change? |
Contributor
Author
|
@matthewjasper would you have the time to open a PR doing the change you propose? I'm a bit swamped at the moment. You can close this PR if you do so. I'll keep this one open for now just as a note to self, to remind me to look at this if there's no movement in the medium term. |
Contributor
|
Opened #91321 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #76168.
I don't think this is the correct way of handling this, but it does get rid of a stable-to-stable regression ICE.
The previous output (before the regression) was:
while the output with this PR is