Conversation
|
r? @dtolnay (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit dc5f2f048c2c82be9fe9fd446ed78efe2952d53e has been approved by |
bors
added
S-waiting-on-bors
devnexen
force-pushed
the
dfly_build_fix
branch
from
dc5f2f0 to
8cc2222
Compare
|
@dtolnay can we use the last commit instead please ? :-) thanks in advance. |
|
@bors r+ |
|
📌 Commit 8cc2222 has been approved by |
ancillary fix dragonfly build
| #[must_use] | ||
| pub fn new() -> SocketCred { | ||
| SocketCred(libc::cmsgcred { cmsgcred_pid: 0, cmsgcred_uid: 0, cmsgcred_gid: 0 }) | ||
| SocketCred(libc::cmsgcred { cmcred_pid: 0, cmcred_uid: 0, cmcred_gid: 0 }) |
There was a problem hiding this comment.
This still appears wrong to me. DragonFly defines additional members in cmsgcred which aren't being referenced here, leading to E0063 when I build this locally. https://github.com/rust-lang/libc/blob/9b054d8779d2f71f1803e20f0e3b3327a4ae2764/src/unix/bsd/freebsdlike/mod.rs#L214-L221
@devnexen are you building these changes locally? My understanding is with DragonFly being a Tier 3 target, this code isn't actually built or tested in PR or CI builds, meaning you can't rely on bors to validate your changes.
I can walk you through building this locally if needed, but I'm concerned that neither this PR nor e68887e were ever actually tested...
There was a problem hiding this comment.
is that the only build error ?
There was a problem hiding this comment.
It is the only error which is not originating as a warning.
Are you set up to build this locally to test your changes?
There was a problem hiding this comment.
is it building for you ? unfortunately I lost my DragonFly VM so I can t test for now.
There was a problem hiding this comment.
sorry for the disturbance, for now better to revert at least that will unblock your situation.
devnexen
force-pushed
the
dfly_build_fix
branch
from
8cc2222 to
b552563
Compare
5 participants
No description provided.