Annotate dead code lint with notes about ignored derived impls#92783
Merged
bors merged 2 commits intorust-lang:masterfrom Jan 19, 2022
Merged
Annotate dead code lint with notes about ignored derived impls#92783bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
camelid
added
the
A-lints
|
Yes, this is more or less what I had in mind! The wording might be tuned very slightly. Right now it seems to say things like It might be slightly more informative to say something to the effect of: My suggestion feels like it might be too verbose, but my thought is to make it clear "yes, we know you have a derived impl of Bar, but we have good reasons not to count that when we're figuring out what's dead." Some wordsmithing help would be good here. I bet some small change will make it much more obvious to the reader. |
nikomatsakis
requested changes
Jan 12, 2022
Contributor
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
Looks nice! I'm wondering if we can improve the output by citing the debug impl itself, perhaps with a message like
= note: this Debug impl exists, but Debug impls are intentionally ignored by the dead code analysis
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 8b459dd has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#88642 (Formally implement let chains) - rust-lang#89621 (doc: guarantee call order for sort_by_cached_key) - rust-lang#91278 (Use iterator instead of recursion in `codegen_place`) - rust-lang#92124 (Little improves in CString `new` when creating from slice) - rust-lang#92783 (Annotate dead code lint with notes about ignored derived impls) - rust-lang#92797 (Remove horizontal lines at top of page) - rust-lang#92920 (Move expr- and item-related pretty printing functions to modules) - rust-lang#93041 (Remove some unused ordering derivations based on `DefId`) - rust-lang#93051 (Add Option::is_some_with and Result::is_{ok,err}_with) - rust-lang#93062 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Hooray! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92726. CC @pmetzger, is this what you had in mind?
r? @nikomatsakis