Better diagnostic for using struct fields in consts#92882
Closed
JulianKnodt wants to merge 1 commit into
Closed
Conversation
Contributor
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
Hahah, I also put up #92884 to address the same issue. My bad for not claiming it when I got interested in it an hour ago. :^) Feel free to steal my implementation from that PR. Just let me know if I should close my PR out in favor for yours, since you got here first. |
Contributor
Author
|
@compiler-errors No I don't mind, feel free to take the content from this PR if you'd like, mine fails CI anyway and it takes me a few hours to fix things on my end so go ahead! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #92776, by printing out a help message if an error was raised when a
.was encountered in a type.cc @estebank since it's diagnostics related