Add note suggesting that predicate may be satisfied, but is not const#93358
Merged
bors merged 2 commits intorust-lang:masterfrom Jan 30, 2022
Merged
Add note suggesting that predicate may be satisfied, but is not const#93358bors merged 2 commits intorust-lang:masterfrom
const#93358bors merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
fee1-dead
approved these changes
Jan 27, 2022
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
Author
erm.. don't think is related. I'll see if this happens locally. |
Contributor
Author
|
@fee1-dead, thanks for the quick PR approval. seems like that CI failure is unrelated, but also I can't retry it. also don't have r= rights to get bors to merge. |
Member
|
@bors r+ |
Collaborator
|
📌 Commit c6de4d5 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit c6de4d5 with merge 063409582d5940bcf6f5e678b9aa4f216c23cad4... |
Collaborator
|
💥 Test timed out |
bors
added
S-waiting-on-review
Member
|
@bors retry |
bors
added
S-waiting-on-bors
Collaborator
Member
|
@bors retry timed out build for aarch64 |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 28, 2022
…1-dead Add note suggesting that predicate may be satisfied, but is not `const` Not sure if we should be printing this in addition to, or perhaps _instead_ of the help message: ``` help: the trait `~const Add` is not implemented for `NonConstAdd` ``` Also added `ParamEnv::is_const` and `PolyTraitPredicate::is_const_if_const` and, in a separate commit, used those in other places instead of `== hir::Constness::Const`, etc. r? `@fee1-dead`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 29, 2022
…1-dead Add note suggesting that predicate may be satisfied, but is not `const` Not sure if we should be printing this in addition to, or perhaps _instead_ of the help message: ``` help: the trait `~const Add` is not implemented for `NonConstAdd` ``` Also added `ParamEnv::is_const` and `PolyTraitPredicate::is_const_if_const` and, in a separate commit, used those in other places instead of `== hir::Constness::Const`, etc. r? ``@fee1-dead``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 29, 2022
…1-dead Add note suggesting that predicate may be satisfied, but is not `const` Not sure if we should be printing this in addition to, or perhaps _instead_ of the help message: ``` help: the trait `~const Add` is not implemented for `NonConstAdd` ``` Also added `ParamEnv::is_const` and `PolyTraitPredicate::is_const_if_const` and, in a separate commit, used those in other places instead of `== hir::Constness::Const`, etc. r? ```@fee1-dead```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 30, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#93256 (Make `join!` description more accurate) - rust-lang#93358 (Add note suggesting that predicate may be satisfied, but is not `const`) - rust-lang#93362 (Do not register infer var for GAT projection in RPIT) - rust-lang#93391 (rustdoc: remove tooltip from source link) - rust-lang#93414 (Move unstable is_{arch}_feature_detected! macros to std::arch) - rust-lang#93441 (rustdoc: load the set of in-scope traits for modules with no docstring) - rust-lang#93459 (fs: Don't copy d_name from struct dirent) - rust-lang#93463 (Rename _args -> args in format_args expansion) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if we should be printing this in addition to, or perhaps instead of the help message:
Also added
ParamEnv::is_constandPolyTraitPredicate::is_const_if_constand, in a separate commit, used those in other places instead of== hir::Constness::Const, etc.r? @fee1-dead