Rename unix::net::SocketAddr::from_path to from_pathname and stabilize it#94356
Merged
bors merged 2 commits intorust-lang:masterfrom Mar 11, 2022
Thomasdezeeuw:stabilize_unix_socket_creation
Merged
Rename unix::net::SocketAddr::from_path to from_pathname and stabilize it#94356bors merged 2 commits intorust-lang:masterfrom Thomasdezeeuw:stabilize_unix_socket_creation
bors merged 2 commits intorust-lang:masterfrom
Thomasdezeeuw:stabilize_unix_socket_creation
Conversation
Matching SocketAddr::as_pathname.
rust-highfive
added
the
S-waiting-on-review
m-ou-se
added
A-io
Member
|
Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
4 tasks
ehuss
reviewed
Feb 25, 2022
Contributor
Author
|
Since the change is so small I've force push to change to stabilise in 1.61. |
rfcbot
added
the
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
removed
the
proposed-final-comment-period
m-ou-se
added
S-waiting-on-fcp
rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
dtolnay
approved these changes
Mar 11, 2022
Member
|
@bors r+ |
Collaborator
|
📌 Commit a84e77b has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 11, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#93293 (Implement `MIN`/`MAX` constants for non-zero integers) - rust-lang#94356 (Rename unix::net::SocketAddr::from_path to from_pathname and stabilize it) - rust-lang#94765 (Rename is_{some,ok,err}_with to is_{some,ok,err}_and.) - rust-lang#94819 (configure: don't serialize empty array elements) - rust-lang#94826 (Improve doc wording for retain on some collections) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Member
|
🎉 Thanks, @Thomasdezeeuw, for pushing this towards stabilization. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilizes
unix_socket_creation.Closes #93423
r? @m-ou-se