store `codegen_fn_attrs` in crate metadata by lcnr · Pull Request #96473 · rust-lang/rust

lcnr · 2022-04-27T08:48:15Z

extracted from #95562 because the change isn't trivial.

rust-highfive · 2022-04-27T08:48:18Z

r? @fee1-dead

(rust-highfive has picked a reviewer for you, use r? to override)

lcnr · 2022-04-27T08:48:30Z

@bors try @rust-timer queue

rust-timer · 2022-04-27T08:48:32Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-04-27T08:48:41Z

⌛ Trying commit 00da420d86e9c4c61da6aa3f22f3d853aa971794 with merge 8bda55c77d599ffd1ee91eba6c0dfa8d31734149...

bors · 2022-04-27T11:29:09Z

☀️ Try build successful - checks-actions
Build commit: 8bda55c77d599ffd1ee91eba6c0dfa8d31734149 (8bda55c77d599ffd1ee91eba6c0dfa8d31734149)

rust-timer · 2022-04-27T11:29:10Z

Queued 8bda55c77d599ffd1ee91eba6c0dfa8d31734149 with parent bb85bca, future comparison URL.

rust-timer · 2022-04-27T12:45:29Z

Finished benchmarking commit (8bda55c77d599ffd1ee91eba6c0dfa8d31734149): comparison url.

Summary:

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	37	32	0	2	37
mean²	0.6%	1.0%	N/A	-0.2%	0.6%
max	1.4%	4.6%	N/A	-0.2%	1.4%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

number of relevant changes ↩
the arithmetic mean of the percent change ↩

lcnr · 2022-04-27T12:51:22Z

maybe caching it on disk if its already simply pulled from the metadata isn't too useful

@bors try @rust-timer queue

rust-timer · 2022-04-27T12:51:23Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-04-27T12:51:29Z

⌛ Trying commit de08cbe2840ae1761852a1a984627c82640b605e with merge 95de7c6d4d85ca601c2838decc62bacf341ca265...

rust-timer · 2022-04-27T12:51:38Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-04-27T14:14:13Z

☀️ Try build successful - checks-actions
Build commit: 95de7c6d4d85ca601c2838decc62bacf341ca265 (95de7c6d4d85ca601c2838decc62bacf341ca265)

rust-timer · 2022-04-27T14:14:15Z

Queued 95de7c6d4d85ca601c2838decc62bacf341ca265 with parent bb85bca, future comparison URL.

rust-timer · 2022-04-27T16:00:52Z

Finished benchmarking commit (95de7c6d4d85ca601c2838decc62bacf341ca265): comparison url.

Summary:

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	38	28	1	2	39
mean²	0.6%	1.0%	-0.3%	-0.2%	0.5%
max	1.5%	4.6%	-0.3%	-0.2%	1.5%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

number of relevant changes ↩
the arithmetic mean of the percent change ↩

lcnr · 2022-04-27T18:22:20Z

alright, this performance decrease seems acceptable, considering that with #95562 we can now remove inline and some other somewhat frequent attributes from the crate metadata which should offset this regression

lcnr · 2022-04-29T09:35:49Z

r? rust-lang/compiler

cjgillot · 2022-04-29T21:59:01Z

Normally, I'd be all for more queries, but the perf result is a bit too large for it's own good. It looks like it is dominated by metadata encoding.

It may be more interesting to land the refactoring in #95562 that makes it possible to omit attributes.
Once this is done, we will be able to identify the cost of the tradeoff in #96473 (comment).

lcnr · 2022-05-09T15:54:04Z

@rustbot ready

klensy · 2022-05-09T16:05:47Z

Finished benchmarking commit (1ceb86c): comparison url.

Improved all, except doc builds (if uncheck all profiles except doc, it can be clearly visible), which regressed.

cjgillot · 2022-05-09T16:17:49Z

r=me with the warning removed.

lcnr · 2022-05-09T16:41:04Z

@bors r=cjgillot

bors · 2022-05-09T16:41:06Z

📌 Commit 32b13ac has been approved by cjgillot

bors · 2022-05-09T19:53:02Z

⌛ Testing commit 32b13ac with merge 88860d5...

bors · 2022-05-09T22:15:25Z

☀️ Test successful - checks-actions
Approved by: cjgillot
Pushing 88860d5 to master...

rust-timer · 2022-05-09T23:33:45Z

Finished benchmarking commit (88860d5): comparison url.

Summary:

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: mixed results

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	6	28	89	39	95
mean²	0.3%	0.6%	-0.5%	-1.6%	-0.4%
max	0.6%	2.2%	-1.4%	-4.8%	-1.4%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

number of relevant changes ↩
the arithmetic mean of the percent change ↩

Fix outdated comment of `fn_can_unwind` The first part is outdated since rust-lang#96473, and the second part is outdated since rust-lang#97235

rust-highfive assigned fee1-dead Apr 27, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 27, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 27, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 27, 2022

lcnr commented Apr 27, 2022

View reviewed changes

Comment thread compiler/rustc_typeck/src/collect.rs Outdated

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Apr 27, 2022

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 27, 2022

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 27, 2022

rust-highfive assigned cjgillot and unassigned fee1-dead Apr 29, 2022

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 9, 2022

lcnr added 2 commits May 9, 2022 18:40

only compute codegen_fn_attrs where needed

d371ebe

review

32b13ac

lcnr force-pushed the querify-codegen-fn-attrs branch from 9dc70c0 to 32b13ac Compare May 9, 2022 16:40

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label May 9, 2022

bors merged commit 88860d5 into rust-lang:master May 9, 2022

rustbot added this to the 1.62.0 milestone May 9, 2022

lcnr deleted the querify-codegen-fn-attrs branch May 10, 2022 06:00

Alexendoo mentioned this pull request May 10, 2022

#[track_caller] on a macro declaration causes ICE #95151

Closed

Aaron1011 mentioned this pull request May 11, 2022

Apply track_caller to closure on expect_non_local() #96894

Merged

nbdd0121 mentioned this pull request Jun 30, 2023

Fix outdated comment of fn_can_unwind #113213

Merged

ZuseZ4 mentioned this pull request Feb 24, 2025

std::autodiff does not work in dependencies #137520

Closed

Uh oh!

Conversation

lcnr commented Apr 27, 2022

Uh oh!

rust-highfive commented Apr 27, 2022

Uh oh!

lcnr commented Apr 27, 2022

Uh oh!

rust-timer commented Apr 27, 2022

Uh oh!

bors commented Apr 27, 2022

Uh oh!

Uh oh!

bors commented Apr 27, 2022

Uh oh!

rust-timer commented Apr 27, 2022

Uh oh!

rust-timer commented Apr 27, 2022

Footnotes

Uh oh!

lcnr commented Apr 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-timer commented Apr 27, 2022

Uh oh!

bors commented Apr 27, 2022

Uh oh!

rust-timer commented Apr 27, 2022

Uh oh!

bors commented Apr 27, 2022

Uh oh!

rust-timer commented Apr 27, 2022

Uh oh!

rust-timer commented Apr 27, 2022

Footnotes

Uh oh!

lcnr commented Apr 27, 2022

Uh oh!

lcnr commented Apr 29, 2022

Uh oh!

cjgillot commented Apr 29, 2022

Uh oh!

lcnr commented May 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

klensy commented May 9, 2022

Uh oh!

cjgillot commented May 9, 2022

Uh oh!

lcnr commented May 9, 2022

Uh oh!

bors commented May 9, 2022

Uh oh!

bors commented May 9, 2022

Uh oh!

bors commented May 9, 2022

Uh oh!

rust-timer commented May 9, 2022

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

lcnr commented Apr 27, 2022 •

edited

Loading

lcnr commented May 9, 2022 •

edited

Loading