Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Mark-Simulacrum
left a comment
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
r=me, modulo nit if you want to resolve that so we don't need to do a rename dance
triagebot.toml
Outdated
There was a problem hiding this comment.
I'm wondering if we should make clearer (i.e., adjust triagebot to have the field name be "cc") that these are really just cc (not really reviewers) -- we're not adding them to github or bors as required reviewers in any sense.
There was a problem hiding this comment.
Yea, that sounds good. I was just copying the highfive layout. I opened rust-lang/triagebot#1628 to rename it.
ehuss
force-pushed
the
triagebot-mentions
branch
from
368e275 to
44e5715
Compare
|
Updated to rename to @bors r=Mark-Simulacrum rollup |
|
📌 Commit 44e5715 has been approved by |
bors
added
S-waiting-on-bors
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#98331 (Fix rustdoc argument error) - rust-lang#98506 (Fix span issues in object safety suggestions) - rust-lang#98563 (interpret: refactor allocation info query) - rust-lang#98576 (small regions refactoring) - rust-lang#98577 (Fix "kind" for associated types in trait implementations in rustdoc JSON) - rust-lang#98578 (Remove eddyb from miri failure pings) - rust-lang#98579 (liballoc tests: avoid int2ptr cast) - rust-lang#98581 (Add triagebot mentions.) - rust-lang#98587 (libcore tests: avoid int2ptr casts) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
|
||
| [mentions."compiler/rustc_mir_transform/src/"] | ||
| message = "Some changes occurred to MIR optimizations" | ||
| cc = ["@rust-lang/mir-opt"] |
There was a problem hiding this comment.
This should have been "wg-mir-opt".
I have not audited the other mention configs, except for the miri ones which seem fine.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
6 participants
This migrates the configuration of mentions from highfive to triagebot.
I also fixed a few broken paths (error_codes.rs src/librustdoc/html/static/themes src/librustdoc/html/static/themes/ayu.css).