Delay formatting trimmed path until lint/error is emitted#99893
Merged
bors merged 2 commits intorust-lang:masterfrom Aug 6, 2022
Merged
Delay formatting trimmed path until lint/error is emitted#99893bors merged 2 commits intorust-lang:masterfrom
bors merged 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
davidtwco
approved these changes
Jul 29, 2022
Member
davidtwco
left a comment
davidtwco
left a comment
There was a problem hiding this comment.
LGTM, one or two comments then feel free to r=me
davidtwco
added
S-waiting-on-author
compiler-errors
force-pushed
the
issue-99387
branch
from
32187dc to
694a010
Compare
Contributor
Author
|
@bors r=davidtwco |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Collaborator
|
Finished benchmarking commit (76b0484): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesThis benchmark run did not return any relevant results for this metric. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
ehuss
pushed a commit
to ehuss/rust
that referenced
this pull request
Aug 31, 2022
Delay formatting trimmed path until lint/error is emitted Fixes rust-lang#99387 r? `@davidtwco`
ehuss
added
the
beta-accepted
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 31, 2022
[BETA] Beta 1.64 backports
* Cargo:
* remove missed reference to workspace inheritance in unstable.md (rust-lang/cargo#11002)
* Delay formatting trimmed path until lint/error is emitted rust-lang#99893
* Use `node_type_opt` to skip over generics that were not expected rust-lang#100155
* Revert "Remove a back-compat hack on lazy TAIT rust-lang#97346" rust-lang#99860
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99387
r? @davidtwco