Skip to content

Recommend running rustfmt last #3733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
topecongiro merged 1 commit into from
Aug 9, 2019
Merged

Recommend running rustfmt last #3733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Recommend running rustfmt last 
As rustfmt checks fail, they might hide errors of more importance.
Running it last makes sure that the serious bugs have been found and is less frustrating.
  • Loading branch information
@skade
skade authored Aug 7, 2019
commit 7944b85f792d263c1fcc0bd4cf6da3b19155f560
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,9 @@ language: rust
before_script:
- rustup component add rustfmt
script:
- cargo fmt --all -- --check
- cargo build
- cargo test
- cargo fmt --all -- --check
```

See [this blog post](https://medium.com/@ag_dubs/enforcing-style-in-ci-for-rust-projects-18f6b09ec69d)
Expand Down