deps: Update syntex_syntax to 0.29.1#847
Merged
Merged
Conversation
Closed
kamalmarhubi
force-pushed
the
update-syntex_syntax
branch
from
a8591a5 to
99de88e
Compare
Contributor
Author
|
Opened #849 to fix nightly build. |
kamalmarhubi
force-pushed
the
update-syntex_syntax
branch
from
99de88e to
589dabd
Compare
Contributor
Author
|
Rebased to pick up #843. |
Member
|
Thanks! (And sorry for the slow review - vacation). |
nrc
added a commit
that referenced
this pull request
Mar 9, 2016
deps: Update syntex_syntax to 0.29.1
Contributor
Author
|
No worries! I hope you enjoyed the vacation :-) |
kamalmarhubi
added a commit
to kamalmarhubi/rustfmt
that referenced
this pull request
Apr 7, 2016
The error handling in libsyntax changed to use a `DiagnosticBuilder` type in the `Err` variant of `PResult`. This type has `emit()` and `cancel()` methods. Once created, errors must be emitted or canceled; if not, the `Drop` impl on `DiagnosticBuilder` will panic. The first syntex_syntax release to include this change was v0.25.0. The bump from v0.23.0 to v0.29.1 in rust-lang#847 did not add any `cancel()` calls, even though at least one was required. There may be others not caught in this commit.
kamalmarhubi
added a commit
to kamalmarhubi/rustfmt
that referenced
this pull request
Apr 7, 2016
The error handling in libsyntax changed to use a `DiagnosticBuilder` type in the `Err` variant of `PResult`. This type has `emit()` and `cancel()` methods. Once created, errors must be emitted or canceled; if not, the `Drop` impl on `DiagnosticBuilder` will panic. The first syntex_syntax release to include this change was v0.25.0. The bump from v0.23.0 to v0.29.1 in rust-lang#847 did not add any `cancel()` calls, even though at least one was required. There may be others not caught in this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.